kern/159353: [patch] conditional call of ifa_del_loopback_route()

[Svatopluk Kraus]

>Number:         159353
>Category:       kern
>Synopsis:       [patch] conditional call of ifa_del_loopback_route()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 01 12:30:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Svatopluk Kraus
>Release:        current
>Organization:
>Environment:
>Description:
ifa_del_loopback_route() is called even if IFA_RT_SELF is not set. It is not consistent and annoying message can be printed.
>How-To-Repeat:

>Fix:
Index: sys/netinet/raw_ip.c
===================================================================
--- sys/netinet/raw_ip.c	(revision 224572)
+++ sys/netinet/raw_ip.c	(working copy)
@@ -761,9 +761,11 @@
 		    || (ifp->if_flags & IFF_POINTOPOINT))
 			flags |= RTF_HOST;

+		if (ia->ia_flags & IFA_RTSELF) {
 		err = ifa_del_loopback_route((struct ifaddr *)ia, sa);
 		if (err == 0)
 			ia->ia_flags &= ~IFA_RTSELF;
+		}

 		err = rtinit(&ia->ia_ifa, RTM_ADD, flags);
 		if (err == 0)


>Release-Note:
>Audit-Trail:
>Unformatted: