misc/156637: sys/types.h can't be included when _XOPEN_SOURCE is defined

[Robert Andersson]

On Mon, 25 Apr 2011 19:10:00 +1000 (EST)
Bruce Evans <brde at optusnet.com.au> wrote:

> 
> I've used the following fix (the first of the above) for 10 years or
> so (it got lost in fixes for mounds of style bugs in <sys/file.h>).
> I didn't notice it in connection with _XOPEN_SOURCE, but by general
> principles.
> 
> % Index: file.h
> % ===================================================================
> % RCS file: /home/ncvs/src/sys/sys/file.h,v
> % retrieving revision 1.65
> % diff -u -2 -r1.65 file.h
> % --- file.h	19 Jun 2004 11:38:00 -0000	1.65
> % +++ file.h	20 Jun 2004 02:11:04 -0000
> % @@ -151,5 +142,5 @@
> %  	void	*xf_data;	/* file descriptor specific
> data */ %  	void	*xf_vnode;	/* vnode pointer */
> % -	u_int	xf_flag;	/* flags (see fcntl.h) */
> % +	unsigned xf_flag;	/* flags (see fcntl.h) */
> %  };
> %
> 
> Bruce
> 
Hi,

Thanks for responding! Your patch definitely solves the problem. I
found this when trying to port an application to FreeBSD. I guess I can
work around the problem by patching the code using file.h
to define __BSD_VISIBLE, but it would be great
if this fix could be committed so that the workaround can be removed
eventually.

Cheers,
Robert