kern/150544: Panic, when viewing the list of ZFS snapshots

[Pawel Jakub Dawidek]

The following reply was made to PR kern/150544; it has been noted by GNATS.

From: Pawel Jakub Dawidek <pjd at FreeBSD.org>
To: Andriy Gapon <avg at freebsd.org>
Cc: jhell <jhell at DataIX.net>, "Vladislav V. Prodan" <universite at ukr.net>,
	bug-followup at freebsd.org, mm at FreeBSD.org
Subject: Re: kern/150544: Panic, when viewing the list of ZFS snapshots
Date: Tue, 14 Sep 2010 09:45:37 +0200

 --MGYHOYXEY6WxJCY8
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Tue, Sep 14, 2010 at 10:25:36AM +0300, Andriy Gapon wrote:
 > on 14/09/2010 09:35 Andriy Gapon said the following:
 > >=20
 > > Maybe this happens because we don't really support .zfs/shares, but cre=
 ate (or
 > > try to create) that directory for some reason?
 > >=20
 >=20
 > Could you please test this patch?
 
 The problem was introduced AFAIK by Martin's import of v15. I think it
 is handled in my v28 properly, but would need to double check. All in
 all, I'd prefer if Martin could handle the problem, as I wasn't involved
 in v15 and it is hard to say for me in what shape it is and what bits
 are missing (Martin CCed).
 
 > --- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c
 > +++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c
 > @@ -128,7 +128,6 @@ static int zfsctl_unmount_snap
 >   */
 >  static gfs_dirent_t zfsctl_root_entries[] =3D {
 >  	{ "snapshot", zfsctl_mknode_snapdir, GFS_CACHE_VNODE },
 > -	{ "shares", zfsctl_mknode_shares, GFS_CACHE_VNODE },
 >  	{ NULL }
 >  };
 
 --=20
 Pawel Jakub Dawidek                       http://www.wheelsystems.com
 pjd at FreeBSD.org                           http://www.FreeBSD.org
 FreeBSD committer                         Am I Evil? Yes, I Am!
 
 --MGYHOYXEY6WxJCY8
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.14 (FreeBSD)
 
 iEYEARECAAYFAkyPKCEACgkQForvXbEpPzSWbgCfcfu5LYdGpgx5pUH9VpgJXSrP
 gs4An2w3lTU3fUEBweLl5mrs4ILHdhig
 =tbVl
 -----END PGP SIGNATURE-----
 
 --MGYHOYXEY6WxJCY8--