kern/150544: Panic, when viewing the list of ZFS snapshots

[Pawel Jakub Dawidek]

The following reply was made to PR kern/150544; it has been noted by GNATS.

From: Pawel Jakub Dawidek <pjd at FreeBSD.org>
To: jhell <jhell at DataIX.net>
Cc: Andriy Gapon <avg at FreeBSD.org>,
	"Vladislav V. Prodan" <universite at ukr.net>,
	bug-followup at FreeBSD.org, mm at FreeBSD.org
Subject: Re: kern/150544: Panic, when viewing the list of ZFS snapshots
Date: Tue, 14 Sep 2010 10:08:20 +0200

 --rMWmSaSbD7nr+du9
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Tue, Sep 14, 2010 at 04:06:34AM -0400, jhell wrote:
 > -----BEGIN PGP SIGNED MESSAGE-----
 > Hash: SHA1
 >=20
 > On 09/14/2010 03:45, Pawel Jakub Dawidek wrote:
 > > On Tue, Sep 14, 2010 at 10:25:36AM +0300, Andriy Gapon wrote:
 > >> on 14/09/2010 09:35 Andriy Gapon said the following:
 > >>>
 > >>> Maybe this happens because we don't really support .zfs/shares, but c=
 reate (or
 > >>> try to create) that directory for some reason?
 > >>>
 > >>
 > >> Could you please test this patch?
 > >=20
 > > The problem was introduced AFAIK by Martin's import of v15. I think it
 > > is handled in my v28 properly, but would need to double check. All in
 > > all, I'd prefer if Martin could handle the problem, as I wasn't involved
 > > in v15 and it is hard to say for me in what shape it is and what bits
 > > are missing (Martin CCed).
 > >=20
 > >> --- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c
 > >> +++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c
 > >> @@ -128,7 +128,6 @@ static int zfsctl_unmount_snap
 > >>   */
 > >>  static gfs_dirent_t zfsctl_root_entries[] =3D {
 > >>  	{ "snapshot", zfsctl_mknode_snapdir, GFS_CACHE_VNODE },
 > >> -	{ "shares", zfsctl_mknode_shares, GFS_CACHE_VNODE },
 > >>  	{ NULL }
 > >>  };
 > >=20
 >=20
 > Andriy,
 > 	That patch-up did solve it. As for what those shares directories are
 > good for I am not sure. Do they effect the sharenfs properties at all ?.
 > If so then I know to not apply this and to just not ls(1) or cd(1) that
 > directory until a more proper fix has been applied.
 >=20
 >=20
 > Pawel,
 > 	Alright future replies if I am reading into it correctly, you will be
 > removed from CC. Thank you for listening && looking in.
 
 I'm happy to be kept on CC, as some of your finding might be interesting
 for v28.
 
 --=20
 Pawel Jakub Dawidek                       http://www.wheelsystems.com
 pjd at FreeBSD.org                           http://www.FreeBSD.org
 FreeBSD committer                         Am I Evil? Yes, I Am!
 
 --rMWmSaSbD7nr+du9
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.14 (FreeBSD)
 
 iEYEARECAAYFAkyPLXQACgkQForvXbEpPzRiawCfT7nl3fVGDsASB4+jJqihajFU
 HPcAoN3ygUcA8JxW2u/O0CAjicl2Jvpw
 =CduR
 -----END PGP SIGNATURE-----
 
 --rMWmSaSbD7nr+du9--