kern/152034: [puc] [patch] SIIG Cyber 2S PCIe not working correcty with puc driver

[Hans Fiedler]

>Number:         152034
>Category:       kern
>Synopsis:       [puc] [patch] SIIG Cyber 2S PCIe not working correcty with puc driver
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 08 04:00:18 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Hans Fiedler
>Release:        8.1-STABLE
>Organization:
University of Louisville
>Environment:
FreeBSD netwatch.louisville.edu 8.1-STABLE FreeBSD 8.1-STABLE #7: Thu Oct 14 20:00:36 EDT 2010     syshans at distribution8.louisville.edu:/usr/obj/usr/src/sys/X3250  amd64


>Description:
The SIIG Cyber 2S PCIe (JJ-E20011) port serial card doesn't seem to function
correctly.  Changing the 'DEFAULT_RCLK *10'seems to get it working correctly.
before patching pucdata.c shows this

devinfo -v

        pcib2 pnpinfo vendor=0x8086 device=0x2940 subvendor=0x1014 subdevice=0x0377 class=0x060400 at slot=28 function=0 handle=\_SB_.PCI0.EXP1
          pci8
            pcib3 pnpinfo vendor=0x104c device=0x8231 subvendor=0x0000 subdevice=0x0000 class=0x060400 at slot=0 function=0 handle=\_SB_.PCI0.EXP1.PXS1
              pci9
                puc0 pnpinfo vendor=0x1415 device=0x950a subvendor=0x131f subdevice=0x2030 class=0x070006 at slot=0 function=0
                  uart2
                  uart3
                  uart4
                  uart5
                unknown pnpinfo vendor=0x1415 device=0x9510 subvendor=0x131f subdevice=0x0000 class=0x070101 at slot=0 function=1

and pciconf -lv

puc0 at pci0:9:0:0:        class=0x070006 card=0x2030131f chip=0x950a1415 rev=0x00 hdr=0x00
    vendor     = 'Oxford Semiconductor Ltd - now part of PLX Technology'
    device     = 'OX16PCI954 Dual PCI UART (??)'
    class      = simple comms
    subclass   = UART
none1 at pci0:9:0:1:       class=0x070101 card=0x0000131f chip=0x95101415 rev=0x00 hdr=0x00
    vendor     = 'Oxford Semiconductor Ltd - now part of PLX Technology'
    device     = 'PCI Interface (disabled) (OX16PCI954)'
    class      = simple comms
    subclass   = parallel port

after, and the ports seem to be working OK

devinfo -v

        pcib2 pnpinfo vendor=0x8086 device=0x2940 subvendor=0x1014 subdevice=0x0377 class=0x060400 at slot=28 function=0 handle=\_SB_.PCI0.EXP1
          pci8
            pcib3 pnpinfo vendor=0x104c device=0x8231 subvendor=0x0000 subdevice=0x0000 class=0x060400 at slot=0 function=0 handle=\_SB_.PCI0.EXP1.PXS1
              pci9
                puc0 pnpinfo vendor=0x1415 device=0x950a subvendor=0x131f subdevice=0x2030 class=0x070006 at slot=0 function=0
                  uart2
                  uart3
                  uart4
                  uart5
                unknown pnpinfo vendor=0x1415 device=0x9510 subvendor=0x131f subdevice=0x0000 class=0x070101 at slot=0 function=1

pciconf -vl

puc0 at pci0:9:0:0:        class=0x070006 card=0x2030131f chip=0x950a1415 rev=0x00 hdr=0x00
    vendor     = 'Oxford Semiconductor Ltd - now part of PLX Technology'
    device     = 'OX16PCI954 Dual PCI UART (??)'
    class      = simple comms
    subclass   = UART
none1 at pci0:9:0:1:       class=0x070101 card=0x0000131f chip=0x95101415 rev=0x00 hdr=0x00
    vendor     = 'Oxford Semiconductor Ltd - now part of PLX Technology'
    device     = 'PCI Interface (disabled) (OX16PCI954)'
    class      = simple comms
    subclass   = parallel port

>How-To-Repeat:
The problem is repeatable in that two ports on the same system can communicate OK, but to external device the data rate of off.
>Fix:
I have a patch I'm attaching, I included the the above devinfo and pciconf as I expect a better solution is to add another device entry, instead if changing the existing info.  Changing the DEFAULT_RCLK on this entry did fix the problem for this device.

Patch attached with submission follows:

*** pucdata.c-ORIG      Wed Oct 13 14:50:51 2010
--- pucdata.c   Sun Nov  7 22:41:15 2010
***************
*** 639,645 ****

        {   0x1415, 0x950a, 0xffff, 0,
            "Oxford Semiconductor OX16PCI954 UARTs",
!           DEFAULT_RCLK,
            PUC_PORT_4S, 0x10, 0, 8,
        },

--- 639,645 ----

        {   0x1415, 0x950a, 0xffff, 0,
            "Oxford Semiconductor OX16PCI954 UARTs",
!           DEFAULT_RCLK * 10,
            PUC_PORT_4S, 0x10, 0, 8,
        },


>Release-Note:
>Audit-Trail:
>Unformatted: