kern/144749: commit references a PR

dfilter service dfilter at FreeBSD.ORG
Tue Mar 30 19:10:26 UTC 2010


The following reply was made to PR kern/144749; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: kern/144749: commit references a PR
Date: Tue, 30 Mar 2010 19:08:20 +0000 (UTC)

 Author: jhb
 Date: Tue Mar 30 19:07:41 2010
 New Revision: 205900
 URL: http://svn.freebsd.org/changeset/base/205900
 
 Log:
   Use panic() (which the environment is required to provide to libstand) to
   implement assert() instead of relying on a non-required exit().  The exit()
   invocation also did not match the semantics of the exit() routine that
   current boot environments happen to require.
   
   PR:		kern/144749
   Discussed with:	bde
   MFC after:	1 week
 
 Modified:
   head/lib/libstand/assert.c
 
 Modified: head/lib/libstand/assert.c
 ==============================================================================
 --- head/lib/libstand/assert.c	Tue Mar 30 19:06:54 2010	(r205899)
 +++ head/lib/libstand/assert.c	Tue Mar 30 19:07:41 2010	(r205900)
 @@ -35,10 +35,10 @@ void
  __assert(const char *func, const char *file, int line, const char *expression)
  {
  	if (func == NULL)
 -		printf("Assertion failed: (%s), file %s, line %d.\n",
 +		panic("Assertion failed: (%s), file %s, line %d.\n",
  		    expression, file, line);
  	else
 -		printf("Assertion failed: (%s), function %s, file %s, line "
 -		    "%d.\n", expression, func, file, line);
 -	exit();
 +		panic(
 +		    "Assertion failed: (%s), function %s, file %s, line %d.\n",
 +		    expression, func, file, line);
  }
 _______________________________________________
 svn-src-all at freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"
 


More information about the freebsd-bugs mailing list