kern/144584: [linprocfs][patch] bogus values in linprocfs
Alexander at Leidinger.net
Fri Mar 26 11:40:06 UTC 2010
The following reply was made to PR kern/144584; it has been noted by GNATS.
From: Alexander Leidinger <Alexander at Leidinger.net>
To: Petr Salinger <Petr.Salinger at seznam.cz>
Cc: bug-followup at FreeBSD.org
Subject: Re: kern/144584: [linprocfs][patch] bogus values in linprocfs
Date: Fri, 26 Mar 2010 12:29:58 +0100
Quoting Petr Salinger <Petr.Salinger at seznam.cz> (from Fri, 26 Mar 2010
12:08:41 +0100 (CET)):
>> mp_maxid needs to be proteced with "#ifdef SMP".
> Does not seem needed in 8.0, anyway, in non-SMP the
> cnt (count of active processors) is clearly 1.
I had a look at other places where it is used, and it is not protected
in all places. So I let it like it is.
>> The following gives an error in a 32bit compile, either cast i to
>> long, or (probably better) change the type in the printf to int.
> change the type in the printf to int as i will be in range 0..99.
Thanks for the confirmation.
"This may be sacrilege to you, but my client can do things for you that even
Mr. Hoover might find out of his range."
-- Tom Hagen, "Chapter 1", page 58
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
More information about the freebsd-bugs