bin/112673: [patch] pkg_add(1): pkg_add -S leaks the temp dir

[Garrett Cooper]

The following reply was made to PR bin/112673; it has been noted by GNATS.

From: Garrett Cooper <yanegomi at gmail.com>
To: bug-followup at FreeBSD.org, jhein at timing.com
Cc:  
Subject: Re: bin/112673: [patch] pkg_add(1): pkg_add -S leaks the temp dir
Date: Tue, 23 Mar 2010 23:33:30 -0700

 Hi John,
     (No one has replied to this PR yet in the past 3 years, so I
 figure I should).
     Yes, I've noted the same as well with my toying around with
 pkg_install over the past couple of days. Something's rotten in terms
 of how the directories are pushed and popped, in fact because many
 times it's not properly pushing and popping the directories in the
 correct / respective order.
     Your patch may resolve this issue, but I'm concerned about the
 case where a tainted directory hasn't been properly cleaned up and
 thus you get some of the contents of package A along with the contents
 of package B in the same directory, instead of properly resolving the
 root cause.
      I'll keep this bug in mind and look at proposing a solution
 sometime in the next couple of weeks.
      And the rewrite isn't completely off -- it's just been put on
 hold until this stuff is fixed :).
 Thanks,
 -Garrett