bin/121165: pkg_add(1) prints a weird message: PKG_TMPDIR environment variable to a location with at least 0 bytes

[Garrett Cooper]

The following reply was made to PR bin/121165; it has been noted by GNATS.

From: Garrett Cooper <yanegomi at gmail.com>
To: bug-followup at FreeBSD.org, yuri at tsoft.com
Cc:  
Subject: Re: bin/121165: pkg_add(1) prints a weird message: PKG_TMPDIR 
	environment variable to a location with at least 0 bytes
Date: Mon, 22 Mar 2010 02:37:06 -0700

 --001636d33fb0b2eaff0482607051
 Content-Type: text/plain; charset=ISO-8859-1
 
     Functions as expected provided test added in
 http://p4web.freebsd.org/chv.cgi?CH=175930 ; I'm just making one minor
 style change from the previous patch so that errx(3) in find_play_pen
 exits with EXIT_FAILURE instead of 2 (I agree that EXIT_FAILURE is
 synonymous to 2, but for it's more readable and consistent as
 EXIT_FAILURE).
 Thanks,
 -Garrett
 
 --001636d33fb0b2eaff0482607051
 Content-Type: application/octet-stream; name="bin.121165.diff"
 Content-Disposition: attachment; filename="bin.121165.diff"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_g73319dw0
 
 PT09PSAvL2RlcG90L3Byb2plY3RzL3NvYzIwMDcvZ2Nvb3Blci1wa2dfaW5zdGFsbC1lbmhhbmNl
 bWVudHMtc2ltcGxpZmllZC91c3Iuc2Jpbi9wa2dfaW5zdGFsbC9hZGQvbWFpbi5jIzIgLSAvc2Ny
 YXRjaC9mcmVlYnNkL3BlcmZvcmNlL3BrZ19pbnN0YWxsLWVuaGFuY2VtZW50cy91c3Iuc2Jpbi9w
 a2dfaW5zdGFsbC9hZGQvbWFpbi5jID09PT0KQEAgLTUwLDYgKzUwLDggQEAKIAogY2hhcgkqKnBr
 Z3M7CiAKK2NoYXIJKnByb2duYW1lCT0gTlVMTDsKKwogc3RydWN0IHsKIAlpbnQgbG93dmVyOwkv
 KiBMb3dlc3QgdmVyc2lvbiBudW1iZXIgdG8gbWF0Y2ggKi8KIAlpbnQgaGl2ZXI7CS8qIEhpZ2hl
 c3QgdmVyc2lvbiBudW1iZXIgdG8gbWF0Y2ggKi8KQEAgLTEyOCw5ICsxMzAsMTIgQEAKICAgICBz
 dGF0aWMgY2hhciB0ZW1wcGFja2FnZXJvb3RbTUFYUEFUSExFTl07CiAgICAgc3RhdGljIGNoYXIg
 cGtnYWRkcGF0aFtNQVhQQVRITEVOXTsKIAotICAgIGlmICgqYXJndlswXSAhPSAnLycgJiYgc3Ry
 Y2hyKGFyZ3ZbMF0sICcvJykgIT0gTlVMTCkKLQlQa2dBZGRDbWQgPSByZWFscGF0aChhcmd2WzBd
 LCBwa2dhZGRwYXRoKTsKLSAgICBlbHNlCisgICAgaWYgKChwcm9nbmFtZSA9IGJhc2VuYW1lKGFy
 Z3ZbMF0pKSA9PSBOVUxMKQorCWVycihFWElUX0ZBSUxVUkUsICJiYXNlbmFtZSIpOworICAgIGlm
 ICgqYXJndlswXSAhPSAnLycgJiYgc3RyY2hyKGFyZ3ZbMF0sICcvJykgIT0gTlVMTCkgeworCWlm
 ICgoUGtnQWRkQ21kID0gcmVhbHBhdGgoYXJndlswXSwgcGtnYWRkcGF0aCkpID09IE5VTEwpCisJ
 ICAgIGVycihFWElUX0ZBSUxVUkUsICJyZWFscGF0aCIpOworICAgIH0gZWxzZQogCVBrZ0FkZENt
 ZCA9IGFyZ3ZbMF07CiAKICAgICBzdGFydCA9IGFyZ3Y7Cj09PT0gLy9kZXBvdC9wcm9qZWN0cy9z
 b2MyMDA3L2djb29wZXItcGtnX2luc3RhbGwtZW5oYW5jZW1lbnRzLXNpbXBsaWZpZWQvdXNyLnNi
 aW4vcGtnX2luc3RhbGwvY3JlYXRlL21haW4uYyMxIC0gL3NjcmF0Y2gvZnJlZWJzZC9wZXJmb3Jj
 ZS9wa2dfaW5zdGFsbC1lbmhhbmNlbWVudHMvdXNyLnNiaW4vcGtnX2luc3RhbGwvY3JlYXRlL21h
 aW4uYyA9PT09CkBAIC00NSw2ICs0NSw3IEBACiBpbnQJSGVscAkJPSBGQUxTRTsKIGVudW0gemlw
 cGVyCVppcHBlciAgPSBCWklQMjsKIAorY2hhcgkqcHJvZ25hbWUJPSBOVUxMOwogCiBzdGF0aWMg
 dm9pZCB1c2FnZSh2b2lkKTsKIApAQCAtNzIsNiArNzMsOCBAQAogICAgIGludCBjaDsKICAgICBj
 aGFyICoqcGtncywgKipzdGFydCwgKnRtcDsKIAorICAgIGlmICgocHJvZ25hbWUgPSBiYXNlbmFt
 ZShhcmd2WzBdKSkgPT0gTlVMTCkKKwllcnIoRVhJVF9GQUlMVVJFLCAiYmFzZW5hbWUiKTsKICAg
 ICBwa2dzID0gc3RhcnQgPSBhcmd2OwogICAgIHdoaWxlICgoY2ggPSBnZXRvcHRfbG9uZyhhcmdj
 LCBhcmd2LCBvcHRzLCBsb25nb3B0cywgTlVMTCkpICE9IC0xKQogCXN3aXRjaChjaCkgewo9PT09
 IC8vZGVwb3QvcHJvamVjdHMvc29jMjAwNy9nY29vcGVyLXBrZ19pbnN0YWxsLWVuaGFuY2VtZW50
 cy1zaW1wbGlmaWVkL3Vzci5zYmluL3BrZ19pbnN0YWxsL2RlbGV0ZS9tYWluLmMjMSAtIC9zY3Jh
 dGNoL2ZyZWVic2QvcGVyZm9yY2UvcGtnX2luc3RhbGwtZW5oYW5jZW1lbnRzL3Vzci5zYmluL3Br
 Z19pbnN0YWxsL2RlbGV0ZS9tYWluLmMgPT09PQpAQCAtMzcsNiArMzcsOCBAQAogQm9vbGVhbglS
 ZWN1cnNpdmUJPSBGQUxTRTsKIG1hdGNoX3QJTWF0Y2hUeXBlCT0gTUFUQ0hfR0xPQjsKIAorY2hh
 cgkqcHJvZ25hbWUJPSBOVUxMOworCiBzdGF0aWMgdm9pZCB1c2FnZSh2b2lkKTsKIAogc3RhdGlj
 IGNoYXIgb3B0c1tdID0gImFkRGZHaGlucDpydnhYIjsKQEAgLTY3LDYgKzY5LDggQEAKICAgICBj
 b25zdCBjaGFyICp0bXA7CiAgICAgc3RydWN0IHN0YXQgc3RhdF9zOwogCisgICAgaWYgKChwcm9n
 bmFtZSA9IGJhc2VuYW1lKGFyZ3ZbMF0pKSA9PSBOVUxMKQorCWVycihFWElUX0ZBSUxVUkUsICJi
 YXNlbmFtZSIpOwogICAgIHBrZ3MgPSBzdGFydCA9IGFyZ3Y7CiAgICAgd2hpbGUgKChjaCA9IGdl
 dG9wdF9sb25nKGFyZ2MsIGFyZ3YsIG9wdHMsIGxvbmdvcHRzLCBOVUxMKSkgIT0gLTEpCiAJc3dp
 dGNoKGNoKSB7Cj09PT0gLy9kZXBvdC9wcm9qZWN0cy9zb2MyMDA3L2djb29wZXItcGtnX2luc3Rh
 bGwtZW5oYW5jZW1lbnRzLXNpbXBsaWZpZWQvdXNyLnNiaW4vcGtnX2luc3RhbGwvaW5mby9tYWlu
 LmMjMSAtIC9zY3JhdGNoL2ZyZWVic2QvcGVyZm9yY2UvcGtnX2luc3RhbGwtZW5oYW5jZW1lbnRz
 L3Vzci5zYmluL3BrZ19pbnN0YWxsL2luZm8vbWFpbi5jID09PT0KQEAgLTM5LDYgKzM5LDggQEAK
 IEJvb2xlYW4gS2VlcFBhY2thZ2UJPSBGQUxTRTsKIHN0cnVjdCB3aGljaF9oZWFkICp3aGVhZDsK
 IAorY2hhcgkqcHJvZ25hbWUJPSBOVUxMOworCiBzdGF0aWMgdm9pZCB1c2FnZSh2b2lkKTsKIAog
 c3RhdGljIGNoYXIgb3B0c1tdID0gImFiY2REZTpFZmdHaGlJamtLbDpMbW9POnBQcVFyUnN0OnZW
 Vzp4WCI7CkBAIC03Myw2ICs3NSw4IEBACiAJZXJyKDIsIE5VTEwpOwogICAgIFRBSUxRX0lOSVQo
 d2hlYWQpOwogCisgICAgaWYgKChwcm9nbmFtZSA9IGJhc2VuYW1lKGFyZ3ZbMF0pKSA9PSBOVUxM
 KQorCWVycihFWElUX0ZBSUxVUkUsICJiYXNlbmFtZSIpOwogICAgIHBrZ3MgPSBzdGFydCA9IGFy
 Z3Y7CiAgICAgaWYgKGFyZ2MgPT0gMSkgewogCU1hdGNoVHlwZSA9IE1BVENIX0FMTDsKPT09PSAv
 L2RlcG90L3Byb2plY3RzL3NvYzIwMDcvZ2Nvb3Blci1wa2dfaW5zdGFsbC1lbmhhbmNlbWVudHMt
 c2ltcGxpZmllZC91c3Iuc2Jpbi9wa2dfaW5zdGFsbC91cGRhdGluZy9tYWluLmMjMSAtIC9zY3Jh
 dGNoL2ZyZWVic2QvcGVyZm9yY2UvcGtnX2luc3RhbGwtZW5oYW5jZW1lbnRzL3Vzci5zYmluL3Br
 Z19pbnN0YWxsL3VwZGF0aW5nL21haW4uYyA9PT09Cj09PT0gLy9kZXBvdC9wcm9qZWN0cy9zb2My
 MDA3L2djb29wZXItcGtnX2luc3RhbGwtZW5oYW5jZW1lbnRzLXNpbXBsaWZpZWQvdXNyLnNiaW4v
 cGtnX2luc3RhbGwvdmVyc2lvbi9tYWluLmMjMSAtIC9zY3JhdGNoL2ZyZWVic2QvcGVyZm9yY2Uv
 cGtnX2luc3RhbGwtZW5oYW5jZW1lbnRzL3Vzci5zYmluL3BrZ19pbnN0YWxsL3ZlcnNpb24vbWFp
 bi5jID09PT0KQEAgLTM2LDYgKzM2LDggQEAKIEJvb2xlYW4gVXNlSU5ERVhPbmx5ID0gRkFMU0U7
 CiBCb29sZWFuIFNob3dPcmlnaW4gPSBGQUxTRTsKIAorY2hhcgkqcHJvZ25hbWUJPSBOVUxMOwor
 CiBzdGF0aWMgdm9pZCB1c2FnZSh2b2lkKTsKIAogc3RhdGljIGNoYXIgb3B0c1tdID0gImRJaGw6
 TDpxczpYdFRPOm92IjsKQEAgLTY3LDYgKzY5LDggQEAKIAljbXAgPSB2ZXJzaW9uX21hdGNoKGFy
 Z3ZbM10sIGFyZ3ZbMl0pOwogCWV4aXQoY21wID09IDEgPyAwIDogMSk7CiAgICAgfQorICAgIGlm
 ICgocHJvZ25hbWUgPSBiYXNlbmFtZShhcmd2WzBdKSkgPT0gTlVMTCkKKwllcnIoRVhJVF9GQUlM
 VVJFLCAiYmFzZW5hbWUiKTsKICAgICBlbHNlIHdoaWxlICgoY2ggPSBnZXRvcHRfbG9uZyhhcmdj
 LCBhcmd2LCBvcHRzLCBsb25nb3B0cywgTlVMTCkpICE9IC0xKSB7CiAJc3dpdGNoKGNoKSB7CiAJ
 Y2FzZSAndic6Cj09PT0gLy9kZXBvdC9wcm9qZWN0cy9zb2MyMDA3L2djb29wZXItcGtnX2luc3Rh
 bGwtZW5oYW5jZW1lbnRzLXNpbXBsaWZpZWQvdXNyLnNiaW4vcGtnX2luc3RhbGwvbGliL3Blbi5j
 IzMgLSAvc2NyYXRjaC9mcmVlYnNkL3BlcmZvcmNlL3BrZ19pbnN0YWxsLWVuaGFuY2VtZW50cy91
 c3Iuc2Jpbi9wa2dfaW5zdGFsbC9saWIvcGVuLmMgPT09PQpAQCAtNjIsMTAgKzYyLDExIEBACiAJ
 Y2xlYW51cCgwKTsKIAlodW1hbml6ZV9udW1iZXIoaHVtYnVmLCBzaXplb2YgaHVtYnVmLCBzeiwg
 IiIsIEhOX0FVVE9TQ0FMRSwKIAkgICAgSE5fTk9TUEFDRSk7Ci0JZXJyeCgyLAotIiVzOiBjYW4n
 dCBmaW5kIGVub3VnaCB0ZW1wb3Jhcnkgc3BhY2UgdG8gZXh0cmFjdCB0aGUgZmlsZXMsIHBsZWFz
 ZSBzZXQgeW91clxuIgotIlBLR19UTVBESVIgZW52aXJvbm1lbnQgdmFyaWFibGUgdG8gYSBsb2Nh
 dGlvbiB3aXRoIGF0IGxlYXN0ICVzIGJ5dGVzXG4iCi0iZnJlZSIsIF9fZnVuY19fLCBodW1idWYp
 OworCS8qIFhYWDogTWFpbnRhaW4gODAgY29sdW1uIHdpZHRoIGluIHRoZSBlcnJvciBtZXNzYWdl
 LiAqLworCWVycngoRVhJVF9GQUlMVVJFLAorCSAgICAiJXMuJXM6IG5vdCBlbm91Z2ggdGVtcG9y
 YXJ5IHNwYWNlIHRvIGV4dHJhY3QgdGhlIGZpbGVzOyBzZXQgUEtHX1RNUERJUiBpblxuIgorCSAg
 ICAieW91ciBlbnZpcm9ubWVudCB0byBhIGxvY2F0aW9uIHdpdGggYXQgbGVhc3QgJXMgYnl0ZXMg
 ZnJlZSIsCisJICAgIHByb2duYW1lLCBfX2Z1bmNfXywgaHVtYnVmKTsKIAlyZXR1cm4gTlVMTDsK
 ICAgICB9CiAgICAgcmV0dXJuIHBlbjsKQEAgLTc5LDcgKzgwLDcgQEAKIHB1c2hQZW4oY29uc3Qg
 Y2hhciAqcGVuKQogewogICAgIGlmICgrK3BkZXB0aCA9PSBNQVhfU1RBQ0spCi0JZXJyeCgyLCAi
 JXM6IHN0YWNrIG92ZXJmbG93LlxuIiwgX19mdW5jX18pOworCWVycngoMiwgIiVzOiBzdGFjayBv
 dmVyZmxvdy5cbiIsIHByb2duYW1lLCBfX2Z1bmNfXyk7CiAgICAgcHN0YWNrW3BkZXB0aF0gPSBz
 dHJkdXAocGVuKTsKIAogICAgIHJldHVybiBwc3RhY2tbcGRlcHRoXTsKQEAgLTEyNyw5ICsxMjgs
 MTAgQEAKICAgICBpZiAobWluX2ZyZWUocGVuKSA8IHN6KSB7CiAJcm1kaXIocGVuKTsKIAljbGVh
 bnVwKDApOwotCWVycngoMiwgIiVzOiBub3QgZW5vdWdoIGZyZWUgc3BhY2UgdG8gY3JlYXRlICcl
 cycuXG4iCisJZXJyeCgyLCAiJXMuJXM6IG5vdCBlbm91Z2ggZnJlZSBzcGFjZSB0byBjcmVhdGUg
 JyVzJy5cbiIKIAkgICAgICJQbGVhc2Ugc2V0IHlvdXIgUEtHX1RNUERJUiBlbnZpcm9ubWVudCB2
 YXJpYWJsZSB0byBhIGxvY2F0aW9uXG4iCi0JICAgICAid2l0aCBtb3JlIHNwYWNlIGFuZFxudHJ5
 IHRoZSBjb21tYW5kIGFnYWluIiwgX19mdW5jX18sIHBlbik7CisJICAgICAid2l0aCBtb3JlIHNw
 YWNlIGFuZFxudHJ5IHRoZSBjb21tYW5kIGFnYWluIiwgcHJvZ25hbWUsIF9fZnVuY19fLAorCSAg
 ICAgcGVuKTsKICAgICB9CiAKICAgICBpZiAoIWdldGN3ZChjd2QsIEZJTEVOQU1FX01BWCkpIHsK
 QEAgLTEzOSw3ICsxNDEsNyBAQAogCiAgICAgaWYgKGNoZGlyKHBlbikgPT0gRkFJTCkgewogCWNs
 ZWFudXAoMCk7Ci0JZXJyeCgyLCAiJXM6IGNhbid0IGNoZGlyIHRvICclcyciLCBfX2Z1bmNfXywg
 cGVuKTsKKwllcnJ4KDIsICIlczolczogY2FuJ3QgY2hkaXIgdG8gJyVzJyIsIHByb2duYW1lLCBf
 X2Z1bmNfXywgcGVuKTsKICAgICB9CiAKICAgICBzdHJjcHkoUGVuTG9jYXRpb24sIHBlbik7CkBA
 IC0xNjMsMTEgKzE2NSwxMSBAQAogCiAgICAgaWYgKGNoZGlyKFBlbkxvY2F0aW9uKSA9PSBGQUlM
 KSB7CiAJY2xlYW51cCgwKTsKLQllcnJ4KDIsICIlczogY2FuJ3QgY2hkaXIgYmFjayB0byAnJXMn
 IiwgX19mdW5jX18sIFBlbkxvY2F0aW9uKTsKKwllcnJ4KDIsICIlcy4lczogY2FuJ3QgY2hkaXIg
 YmFjayB0byAnJXMnIiwgcHJvZ25hbWUsIF9fZnVuY19fLCBQZW5Mb2NhdGlvbik7CiAgICAgfQog
 CiAgICAgaWYgKGxlZnRbMF0gPT0gJy8nICYmIHZzeXN0ZW0oIi9iaW4vcm0gLXJmICVzIiwgbGVm
 dCkpCi0Jd2FybngoImNvdWxkbid0IHJlbW92ZSB0ZW1wb3JhcnkgZGlyICclcyciLCBsZWZ0KTsK
 Kwl3YXJueCgiJXMuJXM6IGNvdWxkbid0IHJlbW92ZSB0ZW1wb3JhcnkgZGlyICclcyciLCBwcm9n
 bmFtZSwgX19mdW5jX18sIGxlZnQpOwogICAgIHNpZ25hbChTSUdJTlQsIG9sZHNpZyk7CiAKICAg
 ICByZXR1cm4gMTsKQEAgLTE3OSw3ICsxODEsNyBAQAogICAgIHN0cnVjdCBzdGF0ZnMgYnVmOwog
 CiAgICAgaWYgKHN0YXRmcyh0bXBkaXIsICZidWYpICE9IDApIHsKLQl3YXJuKCJzdGF0ZnMiKTsK
 Kwl3YXJuKCIlcy4lczogc3RhdGZzIiwgcHJvZ25hbWUsIF9fZnVuY19fKTsKIAlyZXR1cm4gLTE7
 CiAgICAgfQogICAgIHJldHVybiAob2ZmX3QpYnVmLmZfYmF2YWlsICogKG9mZl90KWJ1Zi5mX2Jz
 aXplOwo9PT09IC8vZGVwb3QvcHJvamVjdHMvc29jMjAwNy9nY29vcGVyLXBrZ19pbnN0YWxsLWVu
 aGFuY2VtZW50cy1zaW1wbGlmaWVkL3Vzci5zYmluL3BrZ19pbnN0YWxsL2xpYi9saWIuaCMxIC0g
 L3NjcmF0Y2gvZnJlZWJzZC9wZXJmb3JjZS9wa2dfaW5zdGFsbC1lbmhhbmNlbWVudHMvdXNyLnNi
 aW4vcGtnX2luc3RhbGwvbGliL2xpYi5oID09PT0KQEAgLTMwLDYgKzMwLDggQEAKICNpbmNsdWRl
 IDxzeXMvcXVldWUuaD4KICNpbmNsdWRlIDxjdHlwZS5oPgogI2luY2x1ZGUgPGRpcmVudC5oPgor
 I2luY2x1ZGUgPGVyci5oPgorI2luY2x1ZGUgPGxpYmdlbi5oPgogI2luY2x1ZGUgPHN0ZGFyZy5o
 PgogI2luY2x1ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+CkBAIC0yMzksOSArMjQx
 LDEwIEBACiBpbnQJCXZlcnNpb25fY21wKGNvbnN0IGNoYXIgKiwgY29uc3QgY2hhciAqKTsKIAog
 LyogRXh0ZXJucyAqLworZXh0ZXJuIGNoYXIJKnByb2duYW1lOwogZXh0ZXJuIEJvb2xlYW4JUXVp
 ZXQ7CiBleHRlcm4gQm9vbGVhbglGYWtlOwotZXh0ZXJuIEJvb2xlYW4gIEZvcmNlOworZXh0ZXJu
 IEJvb2xlYW4JRm9yY2U7CiBleHRlcm4gaW50CUF1dG9BbnN3ZXI7CiBleHRlcm4gaW50CVZlcmJv
 c2U7CiAK
 --001636d33fb0b2eaff0482607051--