bin/139606: [patch] pkg_add(1) coredumps silently on atlantis symlink

[Garrett Cooper]

On Sat, Mar 20, 2010 at 11:50 PM, Garrett Cooper <yanegomi at gmail.com> wrote:
> The following reply was made to PR bin/139606; it has been noted by GNATS.
>
> From: Garrett Cooper <yanegomi at gmail.com>
> To: bug-followup at FreeBSD.org, phk at critter.freebsd.dk
> Cc:
> Subject: Re: bin/139606: [patch] pkg_add(1) coredumps silently on atlantis
>        symlink
> Date: Sat, 20 Mar 2010 23:44:06 -0700
>
>  Hi PHK,
>     The goals of this change are good and while this does do a better
>  job than the other proposed change (bin/136419), there's one solitary
>  problem: fexists is used all over the pkg_install code and minus the
>  occasional corner case it's been relatively glitch free. Changing this
>  code to use stat(2) instead of lstat(2) may have some unexpected
>  consequences -- it would probably just be a wiser idea to 1) leave the
>  code alone with the issue documented or 2) implement stat(2) in that
>  section of code, because we know it's a problem section of code that
>  needs to be resolved. Not doing this will result in potential
>  regressive churn if it hasn't been adequately tested with a fine tooth
>  comb.

1. PHK didn't post the reply; Efstratios did (sorry PKH ><).
2. There wasn't actually a solution suggested in the other PR.
Thanks,
-Garrett