misc/148017: rc script for stf does not honour create_flags

[Marcin Wisnicki]

>Number:         148017
>Category:       misc
>Synopsis:       rc script for stf does not honour create_flags
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 20 18:00:11 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Marcin Wisnicki
>Release:        8.1-PRERELEASE
>Organization:
>Environment:
FreeBSD ghost.pnet.one.pl 8.1-PRERELEASE FreeBSD 8.1-PRERELEASE #3: Sun Jun  6 21:14:57 CEST 2010     root at ghost.pnet.one.pl:/home/obj/usr/src/sys/SERWER_DDB  i386
>Description:
If I enable 6to4 with stf_interface_ipv4addr there is no way to set configuration for created interface using create_args_stf0 even though startup scripts create such configuration.

>How-To-Repeat:
cat << EOT >> /etc/rc.conf
ipv6_enable="YES"
stf_interface_ipv4addr="YOUR IP"
create_args_stf0="group ext"
EOT
ifconfig stf0 destroy
/etc/rc.d/network_ipv6 restart
ifconfig -g ext
# no interfaces listed
>Fix:
Apply attached patch

Patch attached with submission follows:

--- etc/network.subr;1	2010-06-06 23:33:07.000000000 +0200
+++ etc/network.subr	2010-06-20 19:05:10.000000000 +0200
@@ -1034,7 +1034,7 @@
 			esac
 			;;
 		esac
-		ifconfig stf0 create >/dev/null 2>&1
+		ifconfig stf0 create `get_if_var stf0 create_args_IF` >/dev/null 2>&1
 		ifconfig stf0 inet6 2002:${ipv4_in_hexformat}:${stf_interface_ipv6_slaid:-0}:${stf_interface_ipv6_ifid} \
 			prefixlen ${stf_prefixlen}
 		# disallow packets to malicious 6to4 prefix


>Release-Note:
>Audit-Trail:
>Unformatted: