misc/148010: bug in net/freeswitch-core

[Richard Neese]

>Number:         148010
>Category:       misc
>Synopsis:       bug in net/freeswitch-core
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 20 15:00:12 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Richard Neese
>Release:        FreeBSD 8.1-RC1 #1
>Organization:
>Environment:
FreeBSD fusionpbx.homeip.net 8.1-RC1 FreeBSD 8.1-RC1 #1: Fri Jun 18 12:52:48 EDT 2010     richard at fusionpbx.homeip.net:/usr/obj/usr/src/sys/PBX  i386

>Description:
The files.freeswitch.in is incorrect for startup. frreeswitch fails to load.
>How-To-Repeat:
install net/freeswitch-core and add freeswitch_enable="YES" to /etc/rc.conf
attempt to use the rc.d/freeswitch script to start . if it starts it puts the pid file in the wron place
>Fix:
changed needed lines to point to the correct place of the pid storage

Patch attached with submission follows:

--- Makefile	2010-06-16 13:26:09.000000000 -0400
+++ Makefile	2010-06-19 12:41:15.000000000 -0400
@@ -1,6 +1,6 @@
 # Ports collection makefile for: freeswitch-core
 # Date created: May 11, 2010
-# Whom: Eric F Crist <ecrist at secure-computing.net>
+# Whom: Richard Neese <r.neese at gmail.com>
 #
 # $FreeBSD: ports/net/freeswitch-core/Makefile,v 1.3 2010/06/16 17:26:09 jpaetzel Exp $
 #
@@ -41,7 +41,7 @@
 		--includedir=${PREFIX}/include/${PORTNAME} \
 		--libdir=${PREFIX}/lib/${PORTNAME}/lib \
 		--with-modinstdir=${PREFIX}/lib/${PORTNAME}/mod \
-		--with-rundir=${VARBASE}/run \
+		--with-rundir=${VARBASE}/run/freeswitch \
 		--with-libgnutls-prefix=${LOCALBASE} \
 		--with-ogg=${LOCALBASE} \
 		--with-ogg-libraries=${LOCALBASE}/lib \
@@ -278,6 +278,8 @@
 	@${CHMOD} -R 774 ${PREFIX}/share/${PORTNAME}
 	@${CHOWN} -R ${FREESWITCH_USER}:${FREESWITCH_GROUP} ${PREFIX}/etc/${PORTNAME}
 	@${CHMOD} -R 774 ${PREFIX}/etc/${PORTNAME}
+	@${MKDIR} ${VARBASE}/run/freeswitch
+	@${CHOWN} -R ${FREESWITCH_USER}:${FREESWITCH_GROUP} ${VARBASE}/run/freeswitch
 
 post-install:
 .if !defined(NOPORTEXAMPLES)
--- files/freeswitch.in	2010-06-11 18:26:44.000000000 -0400
+++ files/freeswitch.in	2010-06-19 12:32:51.000000000 -0400
@@ -18,15 +18,15 @@
 freeswitch_enable=${freeswitch_enable:-"NO"}
 freeswitch_user=${freeswitch_user:-"freeswitch"}
 freeswitch_group=${freeswitch_group:-"freeswitch"}
-freeswitch_flags=${freeswitch_flags:-""}
+freeswitch_flags=${freeswitch_flags:-"-nc -run /var/run/freeswitch -db /var/db/freeswitch -log /var/log/freeswitch"}
 
 name=freeswitch
 rcvar=`set_rcvar`
 
 command=%%PREFIX%%/bin/freeswitch
-command_args="-nc -u ${freeswitch_user} -g ${freeswitch_group} ${freeswitch_flags} -db /var/db/freeswitch -log /var/log/freeswitch/"
+command_args="${freeswitch_flags} ${freeswitch_user} -g ${freeswitch_group}"
 
-pidfile=${freeswitch_pidfile:-"/var/run/freeswitch.pid"}
+pidfile=${freeswitch_pidfile:-"/var/run/freeswitch/freeswitch.pid"}
 
 start_cmd="freeswitch_start"
 stop_precmd="freeswitch_stop"


>Release-Note:
>Audit-Trail:
>Unformatted: