misc/147463: Patch for tools/regression/lib/libc/string/Makefile

[Erik Cederstrand]

>Number:         147463
>Category:       misc
>Synopsis:       Patch for tools/regression/lib/libc/string/Makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 04 08:40:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Erik Cederstrand
>Release:        FreeBSD CURRENT
>Organization:
>Environment:
FreeBSD clangbsd.local 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r208730: Wed Jun  2 19:10:36 CEST 2010     erik at clangbsd.local:/usr/obj/usr/home/erik/freebsd/clang/src/sys/GENERIC  amd64
>Description:
tools/regression/lib/libc/string/Makefile is, in contrast to most other tests, dependent on devel/libtap. Not having ltap library gives an error when running 'make'.

Warn the user what's wrong.
>How-To-Repeat:
cd tools/regression/lib/libc/string/
make
>Fix:
Apply the patch to get better error message.

cd /usr/ports/devel/libtap && make install

to install libtap and be able to build the test

Patch attached with submission follows:

Index: tools/regression/lib/libc/string/Makefile
===================================================================
--- tools/regression/lib/libc/string/Makefile	(revision 208730)
+++ tools/regression/lib/libc/string/Makefile	(working copy)
@@ -6,6 +6,11 @@
 
 TESTS=	test-stpncpy test-strerror test-wcscasecmp test-wcsnlen
 
+LTAP_INSTALLED!= pkg_version | grep libtap
+.if ${LTAP_INSTALLED} == ""
+.error "devel/libtap not installed"
+.endif
+
 .PHONY: tests
 tests: ${TESTS}
 	for p in ${TESTS}; do ${.OBJDIR}/$$p; done


>Release-Note:
>Audit-Trail:
>Unformatted: