misc/143254: groff build in base system does not honor PAGE setting in /etc/make.conf

[Armin Gruner]

>Number:         143254
>Category:       misc
>Synopsis:       groff build in base system does not honor PAGE setting in /etc/make.conf
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 26 11:40:06 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Armin Gruner
>Release:        8.0-RELEASE
>Organization:
muc.de e.V.
>Environment:
FreeBSD ag.techsat.com 8.0-RELEASE-p1 FreeBSD 8.0-RELEASE-p1 #2: Mon Dec 28 15:26:06 CET 2009     ag at ag.techsat.com:/usr/obj/usr/src/sys/AG  i386

>Description:
When building the base system, the PAGE setting in /etc/make.conf is not honored. Thus, the installed devps backend of groff will always emit a ``letter'' papersize postscript document.
>How-To-Repeat:
Goto /usr/src/gnu/usr.bin/groff/font/devps, do a "make" and 
inspect the generated DESC:

$ grep PAGE /etc/make.conf
PAGE=A4

$ grep PAGE /usr/src/gnu/usr.bin/groff/Makefile.inc
PAGE=letter

$ make -C /usr/src/gnu/usr.bin/groff/font/devps

$ grep papersize /usr/obj/usr/src/gnu/usr.bin/groff/font/devps/DESC
papersize letter


>Fix:
Changing PAGE=letter in /usr/src/usr.bin/groff/Makefile.inc to
PAGE?=letter allows to override the make variable. 

See attached patch.

$ grep PAGE /usr/src/gnu/usr.bin/groff/Makefile.inc
PAGE?=letter

$ make -C /usr/src/gnu/usr.bin/groff/font/devps

$ grep papersize /usr/obj/usr/src/gnu/usr.bin/groff/font/devps/DESC
papersize a4


Patch attached with submission follows:

--- gnu/usr.bin/groff/Makefile.inc.orig	2010-01-26 12:20:39.312135241 +0100
+++ gnu/usr.bin/groff/Makefile.inc	2010-01-26 12:30:24.236907165 +0100
@@ -6,7 +6,7 @@
 # Define `page' to be letter if your PostScript printer uses 8.5x11
 # paper (USA) and define it to be A4, if it uses A4 paper (rest of the
 # world).
-PAGE=letter
+PAGE?=letter
 
 # Normally the Postscript driver, grops, produces output that conforms
 # to version 3.0 of the Adobe Document Structuring Conventions.


>Release-Note:
>Audit-Trail:
>Unformatted: