kern/142924: Small cleanup for the inode struct in ext2fs (based on UFS)

Pedro F. Giffuni giffunip at
Sun Jan 24 23:20:13 UTC 2010

I added the equivalent to ufs_lookup.c 1.34:
Bug fixes for currently harmless bugs that could rise to bite
the unwary if the code were called in slightly different ways.

- In ufs_lookup() there is an off-by-one error in the test that checks
if dp->i_diroff is outside the range of the the current directory size.
This is completely harmless, since the following while-loop condition
'dp->i_offset < endsearch' is never met, so the code immediately
does a second pass starting at dp->i_offset = 0.

- Again in ufs_lookup(), the condition in a sanity check is wrong
for directories that are longer than one block. This bug means that

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-ext2fs
Type: application/octet-stream
Size: 2431 bytes
Desc: not available
Url :

More information about the freebsd-bugs mailing list