bin/142384: sync fsck_msdosfs with OpenBSD
antoine at FreeBSD.org
Wed Jan 6 18:40:09 UTC 2010
The following reply was made to PR bin/142384; it has been noted by GNATS.
From: Antoine Brodin <antoine at FreeBSD.org>
To: "Pedro F. Giffuni" <giffunip at tutopia.com>
Cc: freebsd-gnats-submit at freebsd.org
Subject: Re: bin/142384: sync fsck_msdosfs with OpenBSD
Date: Wed, 6 Jan 2010 19:38:06 +0100
On Wed, Jan 6, 2010 at 7:05 PM, Pedro F. Giffuni <giffunip at tutopia.com> wrote:
>> This does not look right, you probably want:
>> if ((n = read(dosfs, block, sizeof(block))) == -1 || n != sizeof(block))
> Hmm... It was taken as-is from OpenBSD's CVS
> but I have no objection with adding the parenthesis.
My problem was with the parenthesis between "n=" and "read" in your patch.
More information about the freebsd-bugs