bin/142384: sync fsck_msdosfs with OpenBSD

Antoine Brodin antoine at
Wed Jan 6 18:40:09 UTC 2010

The following reply was made to PR bin/142384; it has been noted by GNATS.

From: Antoine Brodin <antoine at>
To: "Pedro F. Giffuni" <giffunip at>
Cc: freebsd-gnats-submit at
Subject: Re: bin/142384: sync fsck_msdosfs with OpenBSD
Date: Wed, 6 Jan 2010 19:38:06 +0100

 On Wed, Jan 6, 2010 at 7:05 PM, Pedro F. Giffuni <giffunip at> wrote:
 >> This does not look right, you probably want:
 >> if ((n = read(dosfs, block, sizeof(block))) == -1 || n != sizeof(block))
 > Hmm... It was taken as-is from OpenBSD's CVS
 > but I have no objection with adding the parenthesis.
 My problem was with the parenthesis between "n=" and "read" in your patch.

More information about the freebsd-bugs mailing list