conf/144079: Makefile.inc1 ${DESTDIR} make dependency enhancement

Ruslan Ermilov ru at FreeBSD.org
Fri Feb 19 12:40:03 UTC 2010


The following reply was made to PR conf/144079; it has been noted by GNATS.

From: Ruslan Ermilov <ru at FreeBSD.org>
To: Garrett Cooper <yanegomi at gmail.com>
Cc: bug-followup at FreeBSD.org
Subject: Re: conf/144079: Makefile.inc1 ${DESTDIR} make dependency
 enhancement
Date: Fri, 19 Feb 2010 15:38:02 +0300

 Garrett,
 
 On Thu, Feb 18, 2010 at 11:30:03PM +0000, Garrett Cooper wrote:
 >      The patch on the right track,
 
 I don't think so.  Our install-related targets never create
 directories themselves; instead, they expect them to be pre-
 created, e.g. by mtree.
 
 >  but wasn't complete, so I had to be
 >  a bit more invasive with where the DESTDIR dependencies went (filled
 >  in all missing dependencies based on inspection) and where the goal
 >  itself goes (bsd.own.mk).
 >      I'm not happy about the placement of the goal, and I'm open to
 >  move it to another location if one exists, as bsd.own.mk seems to be
 >  purely variable driven data setting without goals.
 
 Why all this churn, what are you trying to achieve?  Save
 one mkdir command?  Why the proposed ${DESTDIR} dependency
 only covers etc/, include/, and sys/modules/ makefiles?
 
 
 -- 
 Ruslan Ermilov
 ru at FreeBSD.org
 FreeBSD committer


More information about the freebsd-bugs mailing list