kern/153161: IPFIREWALL does not allow specify rules with ICMP codes

[Renato Tambellini]

>Number:         153161
>Category:       kern
>Synopsis:       IPFIREWALL does not allow specify rules with ICMP codes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 15 01:40:10 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Renato Tambellini
>Release:        8.1-STABLE
>Organization:
Private
>Environment:
FreeBSD devilbox.homeunix.net 8.1-STABLE FreeBSD 8.1-STABLE #0: Sun Nov 21 16:38:20 BRST 2010     root at devilbox.homeunix.net:/usr/obj/usr/src/sys/DEVILBOX  amd64
>Description:
The IPFIREWALL does not support specify rules with ICMP codes.

Example:

I try to create a rule to accept packets like this captured in debug mode:
Dec 14 23:08:44 devilbox kernel: ipfw: 400 Accept ICMP:3.4 192.168.1.5 192.168.1.11 in via wlan1

Error when trying to create rule:
# ipfw 500 add allow icmp from 192.168.1.5 to me icmptypes 3.4 
ipfw: invalid ICMP type
Exit 65

RFC792:
ICMP type 3 (destination unreachable)
ICMP type 3, code 4 (fragmentation needed and DF set)

* This problem also occur in all ICMP types and codes.
>How-To-Repeat:
ipfw 500 add allow icmp from 192.168.1.5 to me icmptypes 3.4
>Fix:
Create methods that make possible IPFIREWALL and ipfw interface accept specify ICMP codes.

>Release-Note:
>Audit-Trail:
>Unformatted: