kern/145385: [cpu] Logical processor cannot be disabled for some SMT-enabled Intel procs

Garrett Cooper yaneurabeya at gmail.com
Sun Aug 22 08:20:05 UTC 2010


The following reply was made to PR kern/145385; it has been noted by GNATS.

From: Garrett Cooper <yaneurabeya at gmail.com>
To: bug-followup at FreeBSD.org,
 gcooper at FreeBSD.org
Cc: jhb at FreeBSD.org
Subject: Re: kern/145385: [cpu] Logical processor cannot be disabled for some SMT-enabled Intel procs
Date: Sun, 22 Aug 2010 01:17:37 -0700

 --Apple-Mail-10--784820364
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii
 
 	The following trivial patch fixes the issue on my W3520 =
 processor; AFAICS it's what should be done after reading several of the =
 specs because the logical count that's tracked with ebx is exactly what =
 is needed for logical_cpus (it's an absolute quantity). I need to verify =
 it with a multi-cpu topology at work (the two r710s I was testing with =
 E-series Xeons on aren't available remotely right now).
 Thanks!
 -Garrett
 
 
 --Apple-Mail-10--784820364
 Content-Disposition: attachment;
 	filename=kern-145385.diff
 Content-Type: application/octet-stream;
 	name="kern-145385.diff"
 Content-Transfer-Encoding: 7bit
 
 Index: sys/amd64/amd64/mp_machdep.c
 ===================================================================
 --- sys/amd64/amd64/mp_machdep.c	(revision 211309)
 +++ sys/amd64/amd64/mp_machdep.c	(working copy)
 @@ -203,7 +203,7 @@
  				cnt++;
  		}
  		if (type == CPUID_TYPE_SMT)
 -			cpu_logical = cnt;
 +			cpu_logical = logical_cpus = cnt;
  		else if (type == CPUID_TYPE_CORE)
  			cpu_cores = cnt;
  	}
 
 --Apple-Mail-10--784820364--


More information about the freebsd-bugs mailing list