kern/145960: [patch] mfi(4) - make MFI_STAT_INVALID_STATUS error more apparent in mfi_aen_complete

[Garrett Cooper]

>Number:         145960
>Category:       kern
>Synopsis:       [patch] mfi(4) - make MFI_STAT_INVALID_STATUS error more apparent in mfi_aen_complete
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 22 23:10:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Garrett Cooper
>Release:        9-CURRENT
>Organization:
Cisco Systems, Inc.
>Environment:
FreeBSD bioshock.cisco.com 9.0-CURRENT FreeBSD 9.0-CURRENT #7 r206031: Sat Apr 17 20:20:46 PDT 2010     root at bioshock.cisco.com:/usr/obj/usr/src/sys/BIOSHOCK  amd64
>Description:
The proposed change just makes the error code returned in mfi_aen_complete more apparent by changing 0xff to MFI_STAT_INVALID_STATUS, as MFI_STAT_INVALID_STATUS is 0xff:

$ grep -r MFI_STAT_INVALID_STATUS sys/dev/mfi/mfireg.h 
	MFI_STAT_INVALID_STATUS =	0xFF
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: sys/dev/mfi/mfi.c
===================================================================
--- sys/dev/mfi/mfi.c	(revision 206031)
+++ sys/dev/mfi/mfi.c	(working copy)
@@ -1149,7 +1149,8 @@
 	if (sc->mfi_aen_cm == NULL)
 		return;
 
-	if (sc->mfi_aen_cm->cm_aen_abort || hdr->cmd_status == 0xff) {
+	if (sc->mfi_aen_cm->cm_aen_abort ||
+	    hdr->cmd_status == MFI_STAT_INVALID_STATUS) {
 		sc->mfi_aen_cm->cm_aen_abort = 0;
 		aborted = 1;
 	} else {


>Release-Note:
>Audit-Trail:
>Unformatted: