misc/139135: freebsd-update misbehaves on upgrade and shows errors.

[Fernando]

>Number:         139135
>Category:       misc
>Synopsis:       freebsd-update misbehaves on upgrade and shows errors.
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 25 16:40:00 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Fernando
>Release:        8.0-BETA1
>Organization:
None
>Environment:
FreeBSD hammer 8.0-BETA1 FreeBSD 8.0-BETA1 #1: Mon Jul 13 21:52:19 CEST 2009     root at hammer:/usr/obj/usr/src/sys/APEKERNEL  amd64
>Description:
freebsd-update shows errors like this when trying to update to BETA4:

Fetching files from 8.0-BETA1 for merging... done.
Preparing to download files... done.
/usr/sbin/freebsd-update: cannot open files/.gz: No such file or directory
/usr/sbin/freebsd-update: cannot open files/.gz: No such file or directory
/usr/sbin/freebsd-update: cannot open files/.gz: No such file or directory
/usr/sbin/freebsd-update: cannot open files/.gz: No such file or directory
..
..

Then, some strange things happen, like freebsd-update being unable to merge very simple files and asking the user to merge them manually.

I tried to update to another release (RC1 at this moment) but the same errors are shown. I also tried to remove the whole /var/db/freebsd-update directory. freebsd-update recreated it but the same problems appeared.

I tracked down the problem to the upgrade_merge() function. A lot of files in the 'tomerge' file created by freebsd-update don't exist in the INDEX-PRESENT file.
I don't know if this means a problem in the INDEX-PRESENT file or not.
>How-To-Repeat:
Once freebsd-update shows this error, it is reproducible running freebsd-update -r 8.0-BETA4 upgrade again.
>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: