bin/139751: [patch] fetch/libfetch : NO_PROXY=localhost seems to not work properly.

[Xavier Heiny]

>Number:         139751
>Category:       bin
>Synopsis:       [patch] fetch/libfetch : NO_PROXY=localhost seems to not work properly.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 19 09:00:13 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Xavier Heiny
>Release:        7.0
>Organization:
Netasq
>Environment:
>Description:
fetch/libfetch : NO_PROXY=localhost seems to not work properly.

To make it work, setting NO_PROXY=ocalhost instead of NO_PROXY=localhost is mandatory.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- lib/libfetch/common.c	Wed Feb 16 13:46:46 2005
+++ lib/libfetch/common.c	Tue Sep 17 16:37:23 2009
@@ -772,7 +772,7 @@
 				break;
 
 		d_len = q - p;
-		if (d_len > 0 && h_len > d_len &&
+		if (d_len > 0 && h_len >= d_len &&
 		    strncasecmp(host + h_len - d_len,
 			p, d_len) == 0) {
 			/* domain name matches */


>Release-Note:
>Audit-Trail:
>Unformatted: