kern/139565: ipfilter ioctl SIOCDELST broken

[Jens Kassel]

>Number:         139565
>Category:       kern
>Synopsis:       ipfilter ioctl SIOCDELST broken
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 13 09:00:07 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Jens Kassel
>Release:        FreeBSD 7.2 release
>Organization:
Birdstep
>Environment:
FreeBSD h167.servicefactory.com 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Fri May  1 08:49:13 UTC 2009     root at walker.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
ioctl SIOCDELST always return with error "no such process".
>How-To-Repeat:

>Fix:
Apply the following patch:

--- sys/contrib/ipfilter/netinet/ip_state.c 	2009-10-13 08:03:03.000000000 +0200
+++ sys/contrib/ipfilter/netinet/ip_state.c	2009-10-13 08:04:19.000000000 +0200
@@ -411,7 +411,7 @@
 		if ((sp->is_p == st.is_p) && (sp->is_v == st.is_v) &&
 		    !bcmp((caddr_t)&sp->is_src, (caddr_t)&st.is_src,
 			  sizeof(st.is_src)) &&
-		    !bcmp((caddr_t)&sp->is_dst, (caddr_t)&st.is_src,
+		    !bcmp((caddr_t)&sp->is_dst, (caddr_t)&st.is_dst,
 			  sizeof(st.is_dst)) &&
 		    !bcmp((caddr_t)&sp->is_ps, (caddr_t)&st.is_ps,
 			  sizeof(st.is_ps))) {


>Release-Note:
>Audit-Trail:
>Unformatted: