conf/139040: [patch] 100.clean-disks shouldn't traverse devfs mounts

[Jilles Tjoelker]

The following reply was made to PR conf/139040; it has been noted by GNATS.

From: Jilles Tjoelker <jilles at stack.nl>
To: bug-followup at FreeBSD.org, ryand-freebsd at zenspider.com
Cc:  
Subject: Re: conf/139040: [patch] 100.clean-disks shouldn't traverse devfs
	mounts
Date: Sat, 10 Oct 2009 21:42:07 +0200

 Firstly, 8.x/9.x have all the /dev/fd nodes as character devices which
 will not be traversed.
 
 Secondly, your patch will not work. In fact, the entire
   \( ! -fstype local -o -fstype rdonly \) -a -prune
 part prunes nothing at all, since using -delete anywhere implies -d, and
 -prune does nothing if -d is in effect (this is because -d processes
 directories after their contents so -prune is too late). Because of the
 -o after it, it does, however, exclude all files on such filesystems.
 
 It would make more sense to create a list of mount points to traverse,
 then find through them all with -x, somewhat like
 etc/periodic/security/100.chksetuid does.
 
 -- 
 Jilles Tjoelker