kern/139272: [patch] [psm] disable synaptics mouse taps

[David Horn]

The following reply was made to PR kern/139272; it has been noted by GNATS.

From: David Horn <dhorn2000 at gmail.com>
To: bug-followup at freebsd.org
Cc:  
Subject: Re: kern/139272: [patch] [psm] disable synaptics mouse taps
Date: Thu, 1 Oct 2009 16:47:14 -0400

 --00504502c8b39412c90474e5c0d0
 Content-Type: text/plain; charset=ISO-8859-1
 
 Updated patch to check for synaptics_support tunable, and only act on
 force_tap_events tunable if synaptics_support is disabled. (attached)
 Since this is gmail, the attachment will likely show up garbled in
 gnats web ui, so feel free to email me if you need a copy of the
 updated patch, but it is a 1 line change from the original patch to
 prevent a conflict :
 
 -         if(force_tap_events > 0) {
 +        if(force_tap_events > 0 && ! synaptics_support) {
 
 without this change, setting both tunables caused the mouse to not
 work at all, when the intention is to allow synaptics_support to win
 the tie.
 
 Thanks!
 
 --Dave H
 
 --00504502c8b39412c90474e5c0d0
 Content-Type: text/plain; charset=US-ASCII; name="mouse_taps.patch2.txt"
 Content-Disposition: attachment; filename="mouse_taps.patch2.txt"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_g09z33up0
 
 SW5kZXg6IHNoYXJlL21hbi9tYW40L3BzbS40Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHNoYXJlL21hbi9tYW40
 L3BzbS40CShyZXZpc2lvbiAxOTc2ODIpCisrKyBzaGFyZS9tYW4vbWFuNC9wc20uNAkod29ya2lu
 ZyBjb3B5KQpAQCAtMzU5LDYgKzM1OSwzMyBAQAogVGhpcyB3aWxsIGVuYWJsZQogLk5tCiB0byBo
 YW5kbGUgcGFja2V0cyBmcm9tIGd1ZXN0IGRldmljZXMgKHN0aWNrcykgYW5kIGV4dHJhIGJ1dHRv
 bnMuCisKK0lmIHlvdSB3aXNoIHRvIGRpc2FibGUgU3luYXB0aWNzIHRvdWNocGFkIHRhcCBldmVu
 dHMgKG1vdXNlIHRhcHMpLAorc2V0IAorLlZhIGh3LnBzbS5mb3JjZV90YXBfZXZlbnRzCit0bwor
 LkVtIDIKK2F0IGJvb3QgdGltZS4gIFRoaXMgb25seSBhZmZlY3RzIEdlbmVyaWMKKy5ObQorbW91
 c2Ugc3VwcG9ydAorKGkuZS4gbm90IHdoZW4gRXh0ZW5kZWQgU3luYXB0aWNzIHN1cHBvcnQgaXMg
 ZW5hYmxlZCkKKworQm9vdC10aW1lCisuTm0KK2RldmljZSBkZWJ1Z2dpbmcgaXMgYXZhaWxhYmxl
 IHVzaW5nIHRoZSAKKy5WYSBkZWJ1Zy5wc20ubG9nbGV2ZWwKK3R1bmFibGUuCisgCitUaGVzZSB0
 dW5hYmxlcyBjYW4gYmUgc2V0IGluIC9ib290L2xvYWRlci5jb25mIGFzIC9ldGMvc3lzY3RsLmNv
 bmYKK2V4ZWN1dGVzIHRvbyBsYXRlIGluIHRoZSBib290IHByb2Nlc3MuIChlLmcuIGh3LnBzbS5m
 b3JjZV90YXBfZXZlbnRzPSIyIikKKy5TaCBTWVNDVEwgVkFSSUFCTEVTIAorT25jZSBFeHRlbmRl
 ZCBTeW5hcHRpY3Mgc3VwcG9ydCBpcyBlbmFibGVkLCBtYW55IGFkZGl0aW9uYWwgc3lzY3RsIHZh
 cmlhYmxlcworYmVjb21lIGF2YWlsYWJsZSB0byBjdXN0b21pemUgdGhlIGJlaGF2aW9yIG9mIHRo
 ZSB0b3VjaHBhZC4gU2VlIHN5c2N0bCAtZAorLlZhIGh3LnBzbQorYWZ0ZXIgYm9vdGluZyB3aXRo
 IEV4dGVuZGVkIHN1cHBvcnQgZW5hYmxlZC4KK0RlYnVnIGxvZ2dpbmcgY2FuIGJlIGNvbnRyb2xs
 ZWQgdXNpbmcgdGhlIAorLlZhIGRlYnVnLnBzbS5sb2dsZXZlbAora25vYi4KIC5TaCBJT0NUTFMK
 IFRoZXJlIGFyZSBhIGZldwogLlhyIGlvY3RsIDIKSW5kZXg6IHN5cy9kZXYvYXRrYmRjL3BzbS5j
 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT0KLS0tIHN5cy9kZXYvYXRrYmRjL3BzbS5jCShyZXZpc2lvbiAxOTc2ODIpCisr
 KyBzeXMvZGV2L2F0a2JkYy9wc20uYwkod29ya2luZyBjb3B5KQpAQCAtMzQ2LDYgKzM0Niw5IEBA
 CiBzdGF0aWMgaW50IHN5bmFwdGljc19zdXBwb3J0ID0gMDsKIFRVTkFCTEVfSU5UKCJody5wc20u
 c3luYXB0aWNzX3N1cHBvcnQiLCAmc3luYXB0aWNzX3N1cHBvcnQpOwogCitzdGF0aWMgaW50IGZv
 cmNlX3RhcF9ldmVudHMgPSAwOworVFVOQUJMRV9JTlQoImh3LnBzbS5mb3JjZV90YXBfZXZlbnRz
 IiwgJmZvcmNlX3RhcF9ldmVudHMpOworCiBzdGF0aWMgaW50IHZlcmJvc2UgPSBQU01fREVCVUc7
 CiBUVU5BQkxFX0lOVCgiZGVidWcucHNtLmxvZ2xldmVsIiwgJnZlcmJvc2UpOwogCkBAIC01MDks
 MTAgKzUxMiwyNCBAQAogZW5hYmxlX2F1eF9kZXYoS0JEQyBrYmRjKQogewogCWludCByZXM7Ci0K
 KwlpbnQgY3ZhbCA9IDB4MDA7IAorCQogCXJlcyA9IHNlbmRfYXV4X2NvbW1hbmQoa2JkYywgUFNN
 Q19FTkFCTEVfREVWKTsKIAlWTE9HKDIsIChMT0dfREVCVUcsICJwc206IEVOQUJMRV9ERVYgcmV0
 dXJuIGNvZGU6JTA0eFxuIiwgcmVzKSk7Ci0KKwkKKwkvKiBhbmQgc2V0IHN5bmFwdGljcyB0b3Vj
 aHBhZCB0YXAgbW9kZSBvbmx5IGlmIHR1bmFibGUgaXMgc2V0CisJICAgLSB2YWx1ZSBvZiAxIHdp
 bGwgZm9yY2UgdGFwIGV2ZW50cyAKKwkgICAtIHZhbHVlIG9mIDIgd2lsbCBmb3JjZSBubyB0YXAg
 ZXZlbnRzCisJICAgLSB2YWx1ZSBvZiAwIHdpbGwgbm90IGNoYW5nZSBjdXJyZWN0IHN0YXRlIAor
 CSAgIFRoaXMgb25seSB3b3JrcyB1bmRlciBzdGFuZGFyZCBtb3VzZSBlbXVsYXRpb24gbW9kZSwK
 KwkgICBpZ25vcmVkIGluIGVuaGFuY2VkIHN5bmFwdGljcyBtb2RlICovCisgICAgICAgIGlmIChm
 b3JjZV90YXBfZXZlbnRzID4gMCAmJiAhIHN5bmFwdGljc19zdXBwb3J0KSB7CisJCWlmIChmb3Jj
 ZV90YXBfZXZlbnRzID09IDIpCisJICAgICAgICAJY3ZhbCB8PSAweDA0OworCQltb3VzZV9leHRf
 Y29tbWFuZChrYmRjLCBjdmFsKTsKKwkJc2V0X21vdXNlX3NhbXBsaW5nX3JhdGUoa2JkYywgMjAp
 OworCQlWTE9HKDIsIChMT0dfREVCVUcsICJwc206IHNldCBmb3JjZV90YXBfZXZlbnRzIGNvbW1h
 bmQgYnl0ZSB2YWx1ZSB0bzolMDJ4IFxuIiwgY3ZhbCkpOworCX0KIAlyZXR1cm4gKHJlcyA9PSBQ
 U01fQUNLKTsKIH0KIApAQCAtMjI2Nyw2ICsyMjg0LDggQEAKIHN0YXRpYyBpbnQgdGFwX3RpbWVv
 dXQgPSBQU01fVEFQX1RJTUVPVVQ7CiBTWVNDVExfSU5UKF9od19wc20sIE9JRF9BVVRPLCB0YXBf
 dGltZW91dCwgQ1RMRkxBR19SVywgJnRhcF90aW1lb3V0LCAwLAogICAgICJUYXAgdGltZW91dCBm
 b3IgdG91Y2hwYWRzIik7CitTWVNDVExfSU5UKF9od19wc20sIE9JRF9BVVRPLCBmb3JjZV90YXBf
 ZXZlbnRzLCBDVExGTEFHX1JXLCAmZm9yY2VfdGFwX2V2ZW50cywgMCwKKyAgICAiRm9yY2UgdGFw
 IGV2ZW50cyAwPW5vIGNoYW5nZSAxPWZvcmNlIGV2ZW50cyBvbiAyPWZvcmNlIGV2ZW50cyBvZmYi
 KTsKIAogc3RhdGljIHZvaWQKIHBzbWludHIodm9pZCAqYXJnKQo=
 --00504502c8b39412c90474e5c0d0--