kern/140690: [libc] [patch] swab(3) with negative len should do nothing

[Jeremy Huddleston]

The following reply was made to PR kern/140690; it has been noted by GNATS.

From: Jeremy Huddleston <jeremyhu at apple.com>
To: Paul Procacci <pprocacci at datapipe.com>
Cc: bug-followup at FreeBSD.org
Subject: Re: kern/140690: [libc] [patch] swab(3) with negative len should do nothing
Date: Sat, 21 Nov 2009 09:37:00 -0800

 --Apple-Mail-2--802537417
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii
 
 
 On Nov 21, 2009, at 01:18, Paul Procacci wrote:
 
 > I'd like to add to this.
 >=20
 > As for the length argument.  Is there really ever a time it would have
 > to be signed?
 
 Yes, when passing in a negative value resulting from a subtraction by =
 the caller.
 
 > If not, then I would suggest declaring the type as size_t and not
 > ssize_t much like the read/write/etc syscalls.
 
 It was changed to ssize_t initially to combat the bug I'm reporting, but =
 the fix itself was incomplete.
 
 
 --Apple-Mail-2--802537417
 Content-Disposition: attachment;
 	filename=smime.p7s
 Content-Type: application/pkcs7-signature;
 	name=smime.p7s
 Content-Transfer-Encoding: base64
 
 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIJtzCCAz8w
 ggKooAMCAQICAQ0wDQYJKoZIhvcNAQEFBQAwgdExCzAJBgNVBAYTAlpBMRUwEwYDVQQIEwxXZXN0
 ZXJuIENhcGUxEjAQBgNVBAcTCUNhcGUgVG93bjEaMBgGA1UEChMRVGhhd3RlIENvbnN1bHRpbmcx
 KDAmBgNVBAsTH0NlcnRpZmljYXRpb24gU2VydmljZXMgRGl2aXNpb24xJDAiBgNVBAMTG1RoYXd0
 ZSBQZXJzb25hbCBGcmVlbWFpbCBDQTErMCkGCSqGSIb3DQEJARYccGVyc29uYWwtZnJlZW1haWxA
 dGhhd3RlLmNvbTAeFw0wMzA3MTcwMDAwMDBaFw0xMzA3MTYyMzU5NTlaMGIxCzAJBgNVBAYTAlpB
 MSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUg
 UGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQTCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEA
 xKY8VXNV+065yplaHmjAdQRwnd/p/6Me7L3N9VvyGna9fww6YfK/Uc4B1OVQCjDXAmNaLIkVcI7d
 yfArhVqqP3FWy688Cwfn8R+RNiQqE88r1fOCdz0Dviv+uxg+B79AgAJk16emu59l0cUqVIUPSAR/
 p7bRPGEEQB5kGXJgt/sCAwEAAaOBlDCBkTASBgNVHRMBAf8ECDAGAQH/AgEAMEMGA1UdHwQ8MDow
 OKA2oDSGMmh0dHA6Ly9jcmwudGhhd3RlLmNvbS9UaGF3dGVQZXJzb25hbEZyZWVtYWlsQ0EuY3Js
 MAsGA1UdDwQEAwIBBjApBgNVHREEIjAgpB4wHDEaMBgGA1UEAxMRUHJpdmF0ZUxhYmVsMi0xMzgw
 DQYJKoZIhvcNAQEFBQADgYEASIzRUIPqCy7MDaNmrGcPf6+svsIXoUOWlJ1/TCG4+DYfqi2fNi/A
 9BxQIJNwPP2t4WFiw9k6GX6EsZkbAMUaC4J0niVQlGLH2ydxVyWN3amcOY6MIE9lX5Xa9/eH1sYI
 Tq726jTlEBpbNU1341YheILcIRk13iSx0x1G/11fZU8wggZwMIIF2aADAgECAhBfIA3CIvCJAyf8
 rsNvgxtuMA0GCSqGSIb3DQEBBQUAMGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29u
 c3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNz
 dWluZyBDQTAeFw0wOTA5MTQyMTM2MjdaFw0xMDA5MTQyMTM2MjdaMIICcDEfMB0GA1UEAxMWVGhh
 d3RlIEZyZWVtYWlsIE1lbWJlcjEkMCIGCSqGSIb3DQEJARYVamVyZW15aHVAYmVya2VsZXkuZWR1
 MSswKQYJKoZIhvcNAQkBFhxqZXJlbXlodUB1Y2xpbmsuYmVya2VsZXkuZWR1MSwwKgYJKoZIhvcN
 AQkBFh1qZXJlbXlodUB1Y2xpbms0LmJlcmtlbGV5LmVkdTEnMCUGCSqGSIb3DQEJARYYamVyZW15
 aHVAY3MuYmVya2VsZXkuZWR1MSkwJwYJKoZIhvcNAQkBFhpqZXJlbXlAdXBlLmNzLmJlcmtlbGV5
 LmVkdTEpMCcGCSqGSIb3DQEJARYaamVyZW15aHVAZWVjcy5iZXJrZWxleS5lZHUxJzAlBgkqhkiG
 9w0BCQEWGGplcmVteWh1QGZyZWVkZXNrdG9wLm9yZzEkMCIGCSqGSIb3DQEJARYVamVyZW15aHVA
 bWFjcG9ydHMub3JnMSUwIwYJKoZIhvcNAQkBFhZqZXJlbXlAb3V0ZXJzcXVhcmUub3JnMSAwHgYJ
 KoZIhvcNAQkBFhFqZXJlbXlodWRAbWFjLmNvbTEjMCEGCSqGSIb3DQEJARYUamVyZW15QGh1ZHNj
 YWJpbi5jb20xITAfBgkqhkiG9w0BCQEWEmplcmVteWh1QGFwcGxlLmNvbTElMCMGCSqGSIb3DQEJ
 ARYWamVyZW15QG91dGVyc3F1YXJlLmNvbTElMCMGCSqGSIb3DQEJARYWcGF5cGFsQG91dGVyc3F1
 YXJlLmNvbTEfMB0GCSqGSIb3DQEJARYQamVyZW15aHVkQG1lLmNvbTCCASIwDQYJKoZIhvcNAQEB
 BQADggEPADCCAQoCggEBAL+c2RGHleO3G25PQEPEVsV3H/cWDewBCnMbqV0zgEg3hMyoRUG3aRUg
 H4gWbhVNkx/5t0A+mLQQWNnktg2Jku4MJJhHmarkxQAwITyamyO+37GHFl2d7oe5J7CFwg3Evf/2
 Lli0mfglfDHBy5YN9yURbSMVRaDVWGHhpYkqTwGXG2Bpai7oqdOlB0hDcRGE4Fv5aurxAuxyIohZ
 MuxhZBzDfmidKsOUTnsz+NCUFIXKcMLYWwvH4XOBC4l0SU523phMyEW0OPas38EWd2NMCYaO1URA
 944+cS68DUvCqrrRzGmixY03PcaVuJ/+KA3L2u9esq8vt8s5m8aW8MWQWIkCAwEAAaOCAZEwggGN
 MIIBewYDVR0RBIIBcjCCAW6BFWplcmVteWh1QGJlcmtlbGV5LmVkdYEcamVyZW15aHVAdWNsaW5r
 LmJlcmtlbGV5LmVkdYEdamVyZW15aHVAdWNsaW5rNC5iZXJrZWxleS5lZHWBGGplcmVteWh1QGNz
 LmJlcmtlbGV5LmVkdYEaamVyZW15QHVwZS5jcy5iZXJrZWxleS5lZHWBGmplcmVteWh1QGVlY3Mu
 YmVya2VsZXkuZWR1gRhqZXJlbXlodUBmcmVlZGVza3RvcC5vcmeBFWplcmVteWh1QG1hY3BvcnRz
 Lm9yZ4EWamVyZW15QG91dGVyc3F1YXJlLm9yZ4ERamVyZW15aHVkQG1hYy5jb22BFGplcmVteUBo
 dWRzY2FiaW4uY29tgRJqZXJlbXlodUBhcHBsZS5jb22BFmplcmVteUBvdXRlcnNxdWFyZS5jb22B
 FnBheXBhbEBvdXRlcnNxdWFyZS5jb22BEGplcmVteWh1ZEBtZS5jb20wDAYDVR0TAQH/BAIwADAN
 BgkqhkiG9w0BAQUFAAOBgQBAga5aJmkyd0TMiY0icyR7j5soyooiP4q9+Iu6lG+s/S+7vF5sDadC
 q+Y7US091MNT4LmbQehwwhi4jUWyEZ+KP9dhfWMqi51rZDbhWxAqAoKmgWgoQ9UsA4LqaC1wWlrM
 /DtzZ7+L5ZZ+MWlr94fDNL8qU3+y3ZfiXgpWBV1x1zGCAxAwggMMAgEBMHYwYjELMAkGA1UEBhMC
 WkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0
 ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhBfIA3CIvCJAyf8rsNvgxtuMAkGBSsOAwIa
 BQCgggFvMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTA5MTEyMTE3
 MzcwMFowIwYJKoZIhvcNAQkEMRYEFIutYCezKzXg0BDuaQxNkTzbxfaIMIGFBgkrBgEEAYI3EAQx
 eDB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQu
 MSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQXyANwiLwiQMn
 /K7Db4MbbjCBhwYLKoZIhvcNAQkQAgsxeKB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3
 dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1h
 aWwgSXNzdWluZyBDQQIQXyANwiLwiQMn/K7Db4MbbjANBgkqhkiG9w0BAQEFAASCAQAj3Vp//m1E
 n9CEuh/hO1VtWun9dVslIZ8Dx890rCFp2MdTaz9r7VhsR6nMFTybgFpKiOxTdAQ3XWlUn8mDCxxz
 MLQygyf1CCQiRZXgxR1c7Dck9N4FZyBw7zFgH5P3gNxNOwvmHG19RjbiU/JteFuj17LiNKYMAcLs
 dkBbi3wmlTscbrTLEV12i71X9FjhfkxyLdheTbKb3KDzmeU/ABBwccqzPk0bUjytMlZg642HQBL2
 X4CdJjKaU+hT4S4hQtqKZh+QSdYBMxkXvpFrIwDCCSOOwig86sfHJdxZthJ3N70IsrU1OT5tGyuy
 pTRp6lsiAwSP6OYtnf+U97f7PQyzAAAAAAAA
 
 --Apple-Mail-2--802537417--