kern/119564: commit references a PR

dfilter service dfilter at FreeBSD.ORG
Sat Nov 7 21:50:05 UTC 2009


The following reply was made to PR kern/119564; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: kern/119564: commit references a PR
Date: Sat,  7 Nov 2009 21:46:44 +0000 (UTC)

 Author: attilio
 Date: Sat Nov  7 21:46:34 2009
 New Revision: 199024
 URL: http://svn.freebsd.org/changeset/base/199024
 
 Log:
   Use a safety belt for cases where corrupted narg can be passed to the
   ktrsyscall(). print_number() does decrement the number of arguments,
   leading to infinite loops for negative values.
   
   Reported by:	Patrick Lamaiziere <patpr at davenulle dot org>,
   		Jonathan Pascal <jkpyvxmzsa at mailinator dot com>
   Submitted by:	jh
   PR:		bin/120055, kern/119564
   MFC:		1 week
 
 Modified:
   head/usr.bin/kdump/kdump.c
 
 Modified: head/usr.bin/kdump/kdump.c
 ==============================================================================
 --- head/usr.bin/kdump/kdump.c	Sat Nov  7 21:28:21 2009	(r199023)
 +++ head/usr.bin/kdump/kdump.c	Sat Nov  7 21:46:34 2009	(r199024)
 @@ -799,7 +799,7 @@ ktrsyscall(struct ktr_syscall *ktr)
  				narg--;
  			}
  		}
 -		while (narg) {
 +		while (narg > 0) {
  			print_number(ip,narg,c);
  		}
  		(void)putchar(')');
 _______________________________________________
 svn-src-all at freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"
 


More information about the freebsd-bugs mailing list