kern/135069: commit references a PR
dfilter at FreeBSD.ORG
Sat May 30 09:00:09 UTC 2009
The following reply was made to PR kern/135069; it has been noted by GNATS.
From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Subject: Re: kern/135069: commit references a PR
Date: Sat, 30 May 2009 08:53:26 +0000 (UTC)
Date: Sat May 30 08:53:13 2009
New Revision: 193085
Make ipi_cpu() function as intended.
IPI's in Xen are implemented through hypervisor event channels.
The MP code creates a pair of IRQs for each base IPI per CPU
(one for IPI function dispatch calls, one for IPI bitmap dispatch calls.)
Using PCPU_GET() was returning the IRQ of the IPI handler for the
current CPU; thus calls to ipi_cpu() were sending itself a message.
Instead, looking up the IPI in the target CPU ipi-to-irq map is needed.
Note: This doesn't fix Xen SMP (far from it!) but it at least
sends IPI's to the right places. Next - sending IPIs..
--- head/sys/xen/evtchn/evtchn.c Sat May 30 07:33:32 2009 (r193084)
+++ head/sys/xen/evtchn/evtchn.c Sat May 30 08:53:13 2009 (r193085)
@@ -225,12 +225,15 @@ evtchn_do_upcall(struct trapframe *frame
+ * Send an IPI from the current CPU to the destination CPU.
ipi_pcpu(unsigned int cpu, int vector)
- irq = PCPU_GET(ipi_to_irq[vector]);
+ irq = pcpu_find(cpu)->pc_ipi_to_irq[vector];
svn-src-all at freebsd.org mailing list
To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"
More information about the freebsd-bugs