kern/134355: cooments for m_getm2 inconsistent with behaviour

Martin Karsten mkarsten at cs.uwaterloo.ca
Fri May 8 02:00:12 UTC 2009


>Number:         134355
>Category:       kern
>Synopsis:       cooments for m_getm2 inconsistent with behaviour
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 08 02:00:08 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Martin Karsten
>Release:        7.2
>Organization:
University of Waterloo
>Environment:
FreeBSD i01.expnet 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Fri May  1 08:49:13 UTC 2009     root at walker.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
It seems to me that the comments describing m_getm2 are inconsistent with the behaviour. The comment states that the function returns the top of the newly allocated chain, but it in fact returns the top of the overall chain.

>How-To-Repeat:
N/A

>Fix:
To return the top of the newly allocated chain, the last statement in line 151 would need to be changed from

  return (m);

to

  return (nm);

and the very last else-clause before that is not needed.


>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list