kern/132271: puc support for a generic card

Navdeep Parhar nparhar at gmail.com
Mon Mar 2 17:20:01 PST 2009


>Number:         132271
>Category:       kern
>Synopsis:       puc support for a generic card
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 03 01:20:00 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Navdeep Parhar
>Release:        HEAD 8-CURRENT
>Organization:
Chelsio Communications
>Environment:
FreeBSD pepper 8.0-CURRENT FreeBSD 8.0-CURRENT #6: Mon Mar  2 12:43:40 PST 2009     root at pepper:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
I sent a patch to freebsd-hackers that lets puc recognize and work with a no-brand 1 port serial card.  Mark Linimon suggested that I file a PR so that it doesn't get lost.  This is that PR.

Here is the original message:
http://lists.freebsd.org/pipermail/freebsd-hackers/2009-March/027862.html
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -r 025cb00d19d7 sys/dev/puc/puc.c
--- a/sys/dev/puc/puc.c	Sat Feb 28 12:42:37 2009 -0800
+++ b/sys/dev/puc/puc.c	Mon Mar 02 12:55:26 2009 -0800
@@ -440,9 +440,6 @@
 	sc->sc_dev = dev;
 	sc->sc_cfg = cfg;
 
-	/* We don't attach to single-port serial cards. */
-	if (cfg->ports == PUC_PORT_1S || cfg->ports == PUC_PORT_1P)
-		return (EDOOFUS);
 	error = puc_config(sc, PUC_CFG_GET_NPORTS, 0, &res);
 	if (error)
 		return (error);
diff -r 025cb00d19d7 sys/dev/puc/pucdata.c
--- a/sys/dev/puc/pucdata.c	Sat Feb 28 12:42:37 2009 -0800
+++ b/sys/dev/puc/pucdata.c	Mon Mar 02 12:55:26 2009 -0800
@@ -761,6 +761,12 @@
 	    PUC_PORT_2P, 0x10, 8, 0,
 	}, 
 
+	{   0x9710, 0x9835, 0x1000, 1,
+	    "NetMos NM9835 based 1-port serial",
+	    DEFAULT_RCLK,
+	    PUC_PORT_1S, 0x10, 4, 0,
+	},
+
 	{   0x9710, 0x9835, 0xffff, 0,
 	    "NetMos NM9835 Dual UART and 1284 Printer port",
 	    DEFAULT_RCLK,


>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list