misc/130477: restore doesn't recognize out of space on /tmp

[John Levine]

>Number:         130477
>Category:       misc
>Synopsis:       restore doesn't recognize out of space on /tmp
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 12 22:20:00 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     John Levine
>Release:        7.0
>Organization:
>Environment:
Booted from live FS i386 CD
>Description:
I booted from CD and was restoring filesystems from dumps on a USB disk onto a fresh system disk.  When I tried to restore /var from about a 800MB dump, I got all sorts of strange errors even though the dump was known to be good. After poking around I realized that the problem was there was very little room on /tmp and it filled up. I mounted a reasonable /tmp partition and it worked fine.

Restore of the much larger /usr dump failed immediately, so it appears that some writes to the tmp files check for failure, but some don't.
>How-To-Repeat:
Try to restore a medium sized dump (800MB in my case) on a system with a tiny little /tmp

>Fix:
A quick look at the source code notes several fwrite() calls in dirs.c that don't check the return value.


>Release-Note:
>Audit-Trail:
>Unformatted: