bin/141838: Limits in usr.sbin/rtsold/probe.c false

[Henning Petersen]

>Number:         141838
>Category:       bin
>Synopsis:       Limits in usr.sbin/rtsold/probe.c false
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 21 12:50:00 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Henning Petersen
>Release:        Freebsd-current
>Organization:
>Environment:
>Description:
Limits in usr.sbin/rtsold/probe.c false .
>How-To-Repeat:

>Fix:
diff -u -r1.12 probe.c
--- src/usr.sbin/rtsold/probe.c	7 Nov 2007 10:53:41 -0000	1.12
+++ src/usr.sbin/rtsold/probe.c	21 Dec 2009 11:58:37 -0000
@@ -118,7 +118,7 @@
 		goto closeandend;
 	}
 
-	for (i = 0; dr.defrouter[i].if_index && i < PRLSTSIZ; i++) {
+	for (i = 0; i < DRLSTSIZ && dr.defrouter[i].if_index; i++) {
 		if (ifindex && dr.defrouter[i].if_index == ifindex) {
 			/* sanity check */
 			if (!IN6_IS_ADDR_LINKLOCAL(&dr.defrouter[i].rtaddr)) {


Patch attached with submission follows:

Index: src/usr.sbin/rtsold/probe.c
===================================================================
RCS file: /usr/ncvs/src/usr.sbin/rtsold/probe.c,v
retrieving revision 1.12
diff -u -r1.12 probe.c
--- src/usr.sbin/rtsold/probe.c	7 Nov 2007 10:53:41 -0000	1.12
+++ src/usr.sbin/rtsold/probe.c	21 Dec 2009 11:58:37 -0000
@@ -118,7 +118,7 @@
 		goto closeandend;
 	}
 
-	for (i = 0; dr.defrouter[i].if_index && i < PRLSTSIZ; i++) {
+	for (i = 0; i < DRLSTSIZ && dr.defrouter[i].if_index; i++) {
 		if (ifindex && dr.defrouter[i].if_index == ifindex) {
 			/* sanity check */
 			if (!IN6_IS_ADDR_LINKLOCAL(&dr.defrouter[i].rtaddr)) {


>Release-Note:
>Audit-Trail:
>Unformatted: