bin/92839: contrib/ntp PARSE buffer overrun [patch]
Helge Oldach
freebsdntpd at oldach.net
Sat Sep 6 06:20:47 UTC 2008
After Ollivier's recent update of ntp two buffer overruns still remain.
The patch below fixes them:
--- clk_rawdcf.c 2008-09-06 07:59:47.000000000 +0200
+++ clk_rawdcf.c.ctm 2008-09-04 23:01:34.000000000 +0200
@@ -229,7 +229,7 @@
unsigned char *c = dcfprm->zerobits;
int i;
- parseprintf(DD_RAWDCF,("parse: convert_rawdcf: \"%.*s\"\n", size, buffer));
+ parseprintf(DD_RAWDCF,("parse: convert_rawdcf: \"%s\"\n", buffer));
if (size < 57)
{
@@ -320,7 +320,7 @@
* bad format - not for us
*/
#ifndef PARSEKERNEL
- msyslog(LOG_ERR, "parse: convert_rawdcf: parity check FAILED for \"%.*s\"\n", size, buffer);
+ msyslog(LOG_ERR, "parse: convert_rawdcf: parity check FAILED for \"%s\"\n", buffer);
#endif
return CVT_FAIL|CVT_BADFMT;
}
More information about the freebsd-bugs
mailing list