kern/128801: Bug in if_bce.c:bce_get_media()

[Adam Morrison]

>Number:         128801
>Category:       kern
>Synopsis:       Bug in if_bce.c:bce_get_media()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 11 21:20:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Adam Morrison
>Release:        HEAD
>Organization:
>Environment:
>Description:
There is a bug in if_bce.c:bce_get_media() when checking for SerDes:

	if (sc->bce_phy_flags && BCE_PHY_SERDES_FLAG) {

Note "&&" instead of "&".

The way the code is structured everything works out fine because
->bce_phys_flags will be true iff BCE_PHY_SERDES_FLAG is set.
Still, this is confusing and is a potential error waiting to happen.


>How-To-Repeat:

>Fix:
"&&" -> "&"


>Release-Note:
>Audit-Trail:
>Unformatted: