bin/123703: qualify bad diagnostic in src/usr.sbin/timed/timedc/cmds.c

[Julian H. Stacey" <jhs at berklix.com]

>Number:         123703
>Category:       bin
>Synopsis:       qualify bad diagnostic in src/usr.sbin/timed/timedc/cmds.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 15 14:20:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     "Julian H. Stacey" <jhs at berklix.com>
>Release:        FreeBSD 7.0-RELEASE i386
>Organization:
http://berklix.com BSD Linux Unix Consultancy, Munich/Muenchen.
>Environment:
System: FreeBSD fire.js.berklix.net 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Mon Sep 17 23:01:21 CEST 2007 jhs at fire.js.berklix.net:/usr1/src/sys/amd64/compile/FIRE64.small amd64


	
>Description:
	qualify bad diagnostic in src/usr.sbin/timed/timedc/cmds.c
>How-To-Repeat:
	get remote host as timed master,
	localhost as timed slave,
	then kill remote
	& see local lieing.
>Fix:

	
Copy appended of 
http://berklix.com/~jhs/src/bsd/fixes/freebsd/src/gen/usr.sbin/timed/timed/cmds.c.diff.REL=ALL

Before this patch if the remote master was killed, the local slave lied & said
	communication error with localhost
With this patch the code at least no longer lies.

Patch is hack, 
I would like to read the code & do better, but I dont have time.

the code has not been unchanged for over 4 years 
this diff also applies to 7.0-RELEASE

*** 6.2-RELEASE/src/usr.sbin/timed/timedc/cmds.c	Wed Feb  4 22:59:29 2004
--- new-generic/src/usr.sbin/timed/timedc/cmds.c	Thu May 15 15:20:19 2008
***************
*** 356,361 ****
--- 356,364 ----
  			}
  		} else {
  			printf("communication error with %s\n", tgtname);
+ 			printf(
+ " (A dead remote master is also reported as \"... with localhost\").\n"
+ 				);
  		}
  	} while (++i < argc);
  }


>Release-Note:
>Audit-Trail:
>Unformatted: