misc/122069: /etc/periodic/security/410.logincheck doesn't work

[Taku]

>Number:         122069
>Category:       misc
>Synopsis:       /etc/periodic/security/410.logincheck doesn't work
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 25 15:00:03 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Taku
>Release:        FreeBSD 7.0-RELEASE i386
>Organization:
>Environment:
FreeBSD FreeBSD7 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24 19:59:52 UTC 2008     root at logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
src/etc/periodic/security/410.logincheck contains syntax error.
Semi-colon is missing in line 42.

% sh -n /etc/periodic/security/410.logincheck 
/etc/periodic/security/410.logincheck: 44: Syntax error: "else" unexpected (expecting "then")

>How-To-Repeat:
sh -n /etc/periodic/security/410.logincheck
>Fix:
Following is a patch.
--- /etc/periodic/security/410.logincheck	2008-02-25 02:53:19.000000000 +0900
+++ /tmp/410.logincheck	2008-03-26 08:44:33.000000000 +0900
@@ -39,7 +39,7 @@
     [Yy][Ee][Ss])
 	echo ""
 	echo 'Checking login.conf permissions:'
-	if [ -G /etc/login.conf -a -O /etc/login.conf ] then
+	if [ -G /etc/login.conf -a -O /etc/login.conf ]; then
 	    n=0
 	else
 	    echo "Bad ownership of /etc/login.conf"


>Release-Note:
>Audit-Trail:
>Unformatted: