bin/71613: [PATCH] traceroute(8): cleanup of the usr.sbin/traceroute6 code

[Mark Linimon]

The following reply was made to PR bin/71613; it has been noted by GNATS.

From: linimon at lonesome.com (Mark Linimon)
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: bin/71613: [PATCH] traceroute(8): cleanup of the usr.sbin/traceroute6 code
Date: Sat, 15 Mar 2008 03:26:13 -0500

 ----- Forwarded message from Dan Lukes <dan at obluda.cz> -----
 
 List-Id: Bug reports <freebsd-bugs.freebsd.org>
 
 Bruce Evans napsal/wrote, On 03/15/08 06:06:
 >Using a volatile qualifier instead of a const qualifier gives inconsistent
 >results.  gcc-4.3 always removes "static char volatile copyright[] but
 >doesn't warn about this removal at WARNS > 1.  Not warning is clearly
 >just a bug.  gcc-3.3.3 always keeps this variable, and warns about it
 >being unused at WARNS > 1.
 
 	Hm. It seems the GCCs are not consistent between versions. In 
 	advance, we didn't speak about intel's icc for now.
 
 	I found something that make both proposed patches void. There is 
 defined __COPYRIGHT macro in sys/cdef.h exactly just for such purpose. 
 The cdefs.h logic tried to deal with icc/gcc and gcc.x/gcc.y differences.
 
 	Even new gcc versions or brand new compiler can be handled in one 
 	place.
 
 	So all the 'copyright' places shall be patched using __COPYRIGHT 
 	macro.
 
 
 						Dan
 
 ----- End forwarded message -----