bin/71613: [PATCH] traceroute(8): cleanup of the
usr.sbin/traceroute6 code
bruce at cran.org.uk
bruce at cran.org.uk
Sat Mar 15 01:20:04 UTC 2008
The following reply was made to PR bin/71613; it has been noted by GNATS.
From: bruce at cran.org.uk
To: bug-followup at freebsd.org
Cc: dan at obluda.cz
Subject: Re: bin/71613: [PATCH] traceroute(8): cleanup of the usr.sbin/traceroute6 code
Date: Sat, 15 Mar 2008 01:15:44 +0000
--4Ckj6UjgE2iN1+kY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
I'm not sure 'volatile' is correct in this case - string literals should
be defined 'const' since they can't be changed. Doing this removes the
warning about 'copyright' being unused. I've attached an updated patch.
--
Bruce
--4Ckj6UjgE2iN1+kY
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="traceroute6.c.diff"
--- traceroute6.c.old 2008-03-15 01:07:03.000000000 +0000
+++ traceroute6.c 2008-03-15 01:07:36.000000000 +0000
@@ -66,7 +66,7 @@
*/
#ifndef lint
-static char copyright[] =
+static const char copyright[] =
"@(#) Copyright (c) 1990, 1993\n\
The Regents of the University of California. All rights reserved.\n";
#endif /* not lint */
--4Ckj6UjgE2iN1+kY--
More information about the freebsd-bugs
mailing list