bin/121683: ipfw2 show_nat regression on 7.0-STABLE

Gael Roualland gael.roualland at dial.oleane.com
Fri Mar 14 01:20:02 UTC 2008


>Number:         121683
>Category:       bin
>Synopsis:       ipfw2 show_nat regression on 7.0-STABLE
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 14 01:20:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Gael Roualland
>Release:        7.0-STABLE
>Organization:
>Environment:
FreeBSD jerry.priv 7.0-STABLE FreeBSD 7.0-STABLE #0: Thu Mar 13 21:12:57 CET 2008     gael at jerry:/home/cvsup/obj/home/cvsup/src/sys/JERRY  i386

>Description:
"ipfw show nat config" or "ipfw nat xx config" dumps core in show_nat().
(ipfw2.c rev 1.108.2.3)
>How-To-Repeat:
Add a nat configuration to ipfw rules.
>Fix:
The variable "e" in show_nat is no longer initialized while printing nat configuration since last change;
Trivial diff atatched, thanks.

Patch attached with submission follows:

--- ipfw2.c.orig	2008-03-04 13:07:34.000000000 +0100
+++ ipfw2.c	2008-03-14 02:07:53.000000000 +0100
@@ -5967,6 +5967,7 @@
 			if (frule <= n->id && lrule >= n->id)
 				print_nat_config(&data[i]);
 			i += sizeof(struct cfg_nat);
+			e = (struct cfg_redir *)&data[i];
 			for (redir_cnt = 0; redir_cnt < n->redir_cnt; redir_cnt++) {
 				i += sizeof(struct cfg_redir) + e->spool_cnt * 
 				    sizeof(struct cfg_spool);


>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list