conf/121452: /etc/rc.d/ppp not working as expected

Maksim Yevmenkin maksim.yevmenkin at gmail.com
Fri Mar 7 18:02:37 UTC 2008


On Fri, Mar 7, 2008 at 7:49 AM, Brooks Davis <brooks at freebsd.org> wrote:
> The following patch should allow profile name to contain ".-/+" characters
>  as we do with interfaces.  It also documents the previous undocumnted
>  per-profile overrides of _mode and _nat which were the cause of the problem.
>  If someone who uses ppp could test this, I'd be happy to commit it.

i'm not so sure about this one. if i have "t-dsl" as a profile name, i
will not be able to specify any overrides for this profile, because
shell won't let me have "ppp_t-dsl_mode" and/or "ppp_t-dsl_nat"
variable. so, the translation here is not really needed, imo, and,
perhaps, could even be considered harmful. perhaps we should do one of
the following

1) demand that ppp profile names should be "shell clean" and document it

or

2)  if a ppp profile name is not "shell clean" simply do not evaluate
profile overrides and use defaults

thanks,
max


More information about the freebsd-bugs mailing list