kern/125034: [devfs][patch] devfs does not apply rules to newly created directories

[Mateusz Guzik]

>Number:         125034
>Category:       kern
>Synopsis:       [devfs][patch] devfs does not apply rules to newly created directories
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 27 00:20:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Mateusz Guzik
>Release:        8.0-CURRENT
>Organization:
>Environment:
FreeBSD eternal 8.0-CURRENT FreeBSD 8.0-CURRENT #38: Fri Jun 27 01:55:48 CEST 2008     root at eternal:/usr/obj/usr/src/sys/ETERNAL  i386

>Description:
devfs does not apply rules to newly created directories.
>How-To-Repeat:
# devfs ruleset 10
# devfs rule add path label hide
# devfs rule applyset
# mdconfig -f /tmp/foo
md0
# glabel create foo md0
# ls /dev/label
foo
# devfs rule applyset
# ls /dev/label      
ls: /dev/label: No such file or directory
>Fix:
Patch is attached.

Patch attached with submission follows:

--- sys/fs/devfs/devfs_devs.c.orig	2008-06-27 02:05:34.000000000 +0200
+++ sys/fs/devfs/devfs_devs.c	2008-06-27 02:05:51.119241000 +0200
@@ -422,12 +422,15 @@
 			for (q = s; *q != '/' && *q != '\0'; q++)
 				continue;
 			if (*q != '/')
 				break;
 			de = devfs_find(dd, s, q - s);
-			if (de == NULL)
+			if (de == NULL) {
 				de = devfs_vmkdir(dm, s, q - s, dd, 0);
+				devfs_rules_apply(dm, de);
+			}
+
 			s = q + 1;
 			dd = de;
 		}
 
 		de = devfs_newdirent(s, q - s);


>Release-Note:
>Audit-Trail:
>Unformatted: