bin/45529: [patch] hexdump(1) core-dumps with certain args

[Garrett Cooper]

The following reply was made to PR bin/45529; it has been noted by GNATS.

From: "Garrett Cooper" <yanegomi at gmail.com>
To: bug-followup at FreeBSD.org, drj at pobox.com
Cc:  
Subject: Re: bin/45529: [patch] hexdump(1) core-dumps with certain args
Date: Sat, 21 Jun 2008 13:23:03 -0700

 This patch fixes the issue (at least from what I can tell):
     http://yanegomi-fbsd-patches.googlecode.com/files/hexdump_parse_fix_draft1.patch
 
 I also fixed the regression script:
     http://yanegomi-fbsd-patches.googlecode.com/files/hexdump_regr.sh
 
 Cheers,
 -Garrett
 
 Proof:
 
 [gcooper at optimus /devel/ncvs/src/usr.bin/hexdump]$
 /devel/hexdump_regr.sh hexdump
 hexdump -e "%,"
 hexdump: "%,": bad format
 hexdump -e "/1 "%03","
 hexdump: "/1 "%03",": bad format
 hexdump -e "/1 "\%o","
 hexdump: "/1 "\%o",": bad format
 hexdump -e "/1 "\t%03o","
 hexdump: "/1 "\t%03o",": bad format
 hexdump -e "/1 "\\%03o","
 hexdump: "/1 "\\%03o",": bad format
 hexdump -e "2/1 """
 Segmentation fault (core dumped)
 [gcooper at optimus /devel/ncvs/src/usr.bin/hexdump]$
 /devel/hexdump_regr.sh ./hexdump
 ./hexdump -e "%,"
 hexdump: "%,": bad format
 ./hexdump -e "/1 "%03","
 hexdump: "/1 "%03",": bad format
 ./hexdump -e "/1 "\%o","
 hexdump: "/1 "\%o",": bad format
 ./hexdump -e "/1 "\t%03o","
 hexdump: "/1 "\t%03o",": bad format
 ./hexdump -e "/1 "\\%03o","
 hexdump: "/1 "\\%03o",": bad format
 ./hexdump -e "2/1 """
 hexdump: "2/1 """: bad format