bin/123807: [patch] timed does not run on arm (incorrect getopt usage)

Matthew Luckie mjl at luckie.org.nz
Sun Jun 1 05:30:13 UTC 2008


The following reply was made to PR bin/123807; it has been noted by GNATS.

From: Matthew Luckie <mjl at luckie.org.nz>
To: Giorgos Keramidas <keramida at freebsd.org>
Cc: bug-followup at freebsd.org
Subject: Re: bin/123807: [patch] timed does not run on arm (incorrect getopt
 usage)
Date: Sun, 01 Jun 2008 17:23:33 +1200

 > The first hunk of the patch looks ok, but do we really need the second
 > one too?  There are far too many places where an `int' return from
 > getopt() is compared with '?'-style characters in switch(), so if we
 > don't need it let's not add a cast.
 
 you're right, the cast is not required.


More information about the freebsd-bugs mailing list