bin/100018: newsyslog(8) does not check size if time_at is used

Arne Wörner arne_woerner at yahoo.com
Thu Jul 17 13:01:02 UTC 2008


--- On Thu, 7/17/08, gavin at FreeBSD.org <gavin at FreeBSD.org> wrote:
> -		} else if (ent->hours <= 0 &&
> (ent->flags & CE_TRIMAT)) {
> +		} else if ((ent->hours <= 0 &&
> (ent->flags & CE_TRIMAT)) &&
> +		    check_time_rotate) {
>
thx for ur effort...
unfortunately i do not have any fbsd box currently...

but i did a lazy code inspection and think, that it looks ok...
but:
} else if ((ent->flags & CE_TRIMAT) && check_time_rotate) {
should suffice, since "check_time_rotate" cant become 1 if "ent->hours > 0" or can it? not really sure... :)

-arne


      


More information about the freebsd-bugs mailing list