bin/120162: unable to remount/update gjournaled fs with "current" option

[Niki Denev]

>Number:         120162
>Category:       bin
>Synopsis:       unable to remount/update gjournaled fs with "current" option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 30 17:30:02 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Niki Denev
>Release:        FreeBSD 7.0-BETA2
>Organization:
>Environment:
FreeBSD ndenev 7.0-BETA2 FreeBSD 7.0-BETA2 #5: Sat Nov  3 18:13:12 EET 2007     ndenev at ndenev:/usr/obj/usr/src/sys/XXX  i386
>Description:
When doing mount update with "current" option, mount(8) treats "gjournal" as mount option and tries to apply it. But "gjournal" is a flag, and not an mount option.
>How-To-Repeat:
do a :
# mount -u -ocurrent $fs
on a gjournaled $fs filesystem.
>Fix:
The applied patch to mount.c:flags2opts() fixes the problem by not reporting "gjournal" as option.


Patch attached with submission follows:

--- sbin/mount/mount.c.orig	2008-01-30 19:15:20.000000000 +0200
+++ sbin/mount/mount.c	2008-01-30 19:16:09.000000000 +0200
@@ -871,7 +871,6 @@
 	if (flags & MNT_SUIDDIR)	res = catopt(res, "suiddir");
 	if (flags & MNT_MULTILABEL)	res = catopt(res, "multilabel");
 	if (flags & MNT_ACLS)		res = catopt(res, "acls");
-	if (flags & MNT_GJOURNAL)	res = catopt(res, "gjournal");
 
 	return (res);
 }


>Release-Note:
>Audit-Trail:
>Unformatted: