bin/119705: [PATCH] make iostat a bit smarter about the number of tty rows

Maxim Konovalov maxim at macomnet.ru
Wed Jan 16 07:00:06 UTC 2008


The following reply was made to PR bin/119705; it has been noted by GNATS.

From: Maxim Konovalov <maxim at macomnet.ru>
To: Giorgos Keramidas <keramida at freebsd.org>
Cc: Bruce Evans <bde at freebsd.org>, bug-followup at freebsd.org
Subject: Re: bin/119705: [PATCH] make iostat a bit smarter about the number
 of tty rows
Date: Wed, 16 Jan 2008 09:29:16 +0300 (MSK)

 Hi Giorgos,
 
 It seems for me you forget to clear wresized flag -- I added
 printf("%s\n", __func__); at the beginning of doresize() to notice
 this.
 
 IMHO the isatty() check doesn't belong to a pseudo signal handler
 doresize().  Install SIGWINCH handler if and only if stdout is a tty.
 
 Do you have plans to add this feature to netstat, vmstat and all other
 similar tools? :-)
 
 -- 
 Maxim Konovalov


More information about the freebsd-bugs mailing list