kern/119604: [patch] remove superfluous line in sys/kern/subr_autoconf.c

Antoine Brodin antoine.brodin at laposte.net
Sat Jan 12 09:00:01 PST 2008


>Number:         119604
>Category:       kern
>Synopsis:       [patch] remove superfluous line in sys/kern/subr_autoconf.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 12 17:00:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Antoine Brodin
>Release:        FreeBSD 8.0-CURRENT i386
>Organization:
none
>Environment:
System: FreeBSD barton.dreadbsd.org. 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Sun Jan 6 15:52:17 CET 2008 root at barton.dreadbsd.org.:/usr/obj/usr/src/sys/BARTON i386


>Description:
There is a superfluous line in sys/kern/subr_autoconf.c:run_interrupt_driven_config_hooks
The "next_entry = TAILQ_NEXT(hook_entry, ich_links);" is not necessary
since TAILQ_FOREACH_SAFE is used.
>How-To-Repeat:
>Fix:


--- subr_autoconf.c.diff begins here ---
Index: subr_autoconf.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/subr_autoconf.c,v
retrieving revision 1.23
diff -u -p -r1.23 subr_autoconf.c
--- subr_autoconf.c	19 Jul 2006 18:53:56 -0000	1.23
+++ subr_autoconf.c	30 Dec 2007 19:39:36 -0000
@@ -67,7 +67,6 @@ run_interrupt_driven_config_hooks(dummy)
 	mtx_lock(&intr_config_hook_lock);
 	TAILQ_FOREACH_SAFE(hook_entry, &intr_config_hook_list, ich_links,
 	    next_entry) {
-		next_entry = TAILQ_NEXT(hook_entry, ich_links);
 		mtx_unlock(&intr_config_hook_lock);
 		(*hook_entry->ich_func)(hook_entry->ich_arg);
 		mtx_lock(&intr_config_hook_lock);
--- subr_autoconf.c.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list