bin/120784: [patch] mount(8): allow mount from fstab with 3rd party tools like ntfs-3g

[Yoshihiro Ota]

The following reply was made to PR bin/120784; it has been noted by GNATS.

From: Yoshihiro Ota <ota at j.email.ne.jp>
To: bug-followup at FreeBSD.org
Cc: kamikaze at bsdforen.de
Subject: Re: bin/120784: [patch] mount(8): allow mount from fstab with 3rd
 party tools like ntfs-3g
Date: Thu, 21 Feb 2008 01:17:06 -0500

 This is a multi-part message in MIME format.
 
 --Multipart=_Thu__21_Feb_2008_01_17_06_-0500_zWgRYxXQvZ/tL5k/
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 
 This problem was mentioned last February and long standing bug,
 i.e. http://docs.freebsd.org/cgi/getmsg.cgi?fetch=282404+0+archive/2007/freebsd-current/20070204.freebsd-current
 
 In 7-release, mount program is modified to rely on nmount system call
 based on the source code change I read.
 
 The implementation to detect whether it is to call nmount or mount_XXX
 is determined by a list of KNOWN external mount programs.  THAT is the
 problem as I mentioned one year ago.  mount(3) is more tied to nmount(2)
 so that it is more reasonable and appropriate to list all nmount2) supported
 file systems like my patch.  This is another alternative to this problem.
 
 --Multipart=_Thu__21_Feb_2008_01_17_06_-0500_zWgRYxXQvZ/tL5k/
 Content-Type: text/x-diff;
  name="mount_xxx.diff"
 Content-Disposition: attachment;
  filename="mount_xxx.diff"
 Content-Transfer-Encoding: 7bit
 
 ? mount.diff
 Index: mount.c
 ===================================================================
 RCS file: /home/ncvs/src/sbin/mount/mount.c,v
 retrieving revision 1.96
 diff -u -r1.96 mount.c
 --- mount.c	25 Jun 2007 05:06:54 -0000	1.96
 +++ mount.c	21 Feb 2008 06:11:45 -0000
 @@ -134,17 +134,20 @@
  	 */
  	unsigned int i;
  	const char *fs[] = {
 -	"cd9660", "mfs", "msdosfs", "nfs", "nfs4", "ntfs",
 -	"nwfs", "nullfs", "portalfs", "smbfs", "udf", "unionfs",
 +	"ufs",
 +	"tmpfs",
 +	"ext2fs",
 +	"devfs", "fdescfs", "procfs", "linprocfs", "linsysfs",
 +	"std",
  	NULL
  	};
  
  	for (i = 0; fs[i] != NULL; ++i) {
  		if (strcmp(vfstype, fs[i]) == 0)
 -			return (1);
 +			return (0);
  	}
  	
 -	return (0);
 +	return (1);
  }
  
  static int
 
 --Multipart=_Thu__21_Feb_2008_01_17_06_-0500_zWgRYxXQvZ/tL5k/--