kern/120587: TCP_DROP_SYNFIN isn't at all gone on 6.3 and RELENG_6

[Ighighi]

>Number:         120587
>Category:       kern
>Synopsis:       TCP_DROP_SYNFIN isn't at all gone on 6.3 and RELENG_6
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 13 00:40:02 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Ighighi
>Release:        6.3-STABLE
>Organization:
>Environment:
FreeBSD orion 6.3-STABLE FreeBSD 6.3-STABLE #0: Tue Feb 12 10:18:06 VET 2008     root at orion.nebula.mil:/usr/obj/usr/src/sys/CUSTOM  i386
>Description:
According to the CVS log of rc.conf(5), TCP_DROP_SYNFIN is no longer needed for 
setting tcp_drop_synfin.  It is not the case...

Quoting:
http://www.FreeBSD.org/cgi/cvsweb.cgi/src/share/man/man5/rc.conf.5?only_with_tag=RELENG_6

"MFC rev. 1.322 rc.conf, rev. 1.332 rc.conf.5: TCP_DROP_SYNFIN has gone"
>How-To-Repeat:
$ fgrep -r TCP_DROP_SYNFIN /usr/src/sys
/usr/src/sys/conf/NOTES:# TCP_DROP_SYNFIN adds support for ignoring TCP packets with SYN+FIN. This
/usr/src/sys/conf/NOTES:options         TCP_DROP_SYNFIN         #drop TCP packets with SYN+FIN
/usr/src/sys/conf/options:TCP_DROP_SYNFIN               opt_tcp_input.h
/usr/src/sys/netinet/tcp_input.c:#ifdef TCP_DROP_SYNFIN
/usr/src/sys/netinet/tcp_input.c:#ifdef TCP_DROP_SYNFIN

>Fix:
Either undo the changes to rc.conf(5) on RELENG_6 or truly drop TCP_DROP_SYNFIN

>Release-Note:
>Audit-Trail:
>Unformatted: