kern/126368: Running ktrace/kdump in jail leads to stale jails

[Mateusz Guzik]

The following reply was made to PR kern/126368; it has been noted by GNATS.

From: "Mateusz Guzik" <mjguzik at gmail.com>
To: bug-followup at freebsd.org
Cc:  
Subject: Re: kern/126368: Running ktrace/kdump in jail leads to stale jails
Date: Fri, 8 Aug 2008 16:47:49 +0200

 ------=_Part_50034_12786102.1218206869075
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 Hi,
 
 the same problems exists in CURRENT. It seems that ktr_writerequest()
 calls crhold() on credentials, but doesn't free it when exiting.
 Attached patch (simple crfree() before return) fixes this problem (at
 least for me :>).
 
 Thanks,
 --
 Mateusz Guzik
 
 ------=_Part_50034_12786102.1218206869075
 Content-Type: application/octet-stream; name=kern_ktrace.diff
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_fjmwvn4l0
 Content-Disposition: attachment; filename=kern_ktrace.diff
 
 LS0tIHN5cy9rZXJuL2tlcm5fa3RyYWNlLmMub3JpZwkyMDA4LTA4LTA4IDE2OjM3OjQ1LjAwMDAw
 MDAwMCArMDIwMAorKysgc3lzL2tlcm4va2Vybl9rdHJhY2UuYwkyMDA4LTA4LTA4IDE2OjM4OjIx
 LjAwMDAwMDAwMCArMDIwMApAQCAtOTMzLDEwICs5MzMsMTEgQEAKIAkJZXJyb3IgPSBWT1BfV1JJ
 VEUodnAsICZhdWlvLCBJT19VTklUIHwgSU9fQVBQRU5ELCBjcmVkKTsKIAlWT1BfVU5MT0NLKHZw
 LCAwLCB0ZCk7CiAJdm5fZmluaXNoZWRfd3JpdGUobXApOwogCXZyZWxlKHZwKTsKIAlWRlNfVU5M
 T0NLX0dJQU5UKHZmc2xvY2tlZCk7CisJY3JmcmVlKGNyZWQpOwogCWlmICghZXJyb3IpCiAJCXJl
 dHVybjsKIAkvKgogCSAqIElmIGVycm9yIGVuY291bnRlcmVkLCBnaXZlIHVwIHRyYWNpbmcgb24g
 dGhpcyB2bm9kZS4gIFdlIGRlZmVyCiAJICogYWxsIHRoZSB2cmVsZSgpJ3Mgb24gdGhlIHZub2Rl
 IHVudGlsIGFmdGVyIHdlIGFyZSBmaW5pc2hlZCB3YWxraW5nCg==
 ------=_Part_50034_12786102.1218206869075--